1509315 - Refactor all tests involving a real tab to use TargetFactory.forTab to create a target front

Status: RESOLVED FIXED

(DevTools :: Framework, enhancement, P2)

Description

[Alexandre Poirot [:ochameau]]

For now, most of the tests are using TargetFactory.forTab for accessing to the target front, but there is still a couple manually creating only the front and not a Target by create its own DebuggerClient, querying listTabs manually and calling DebuggerClient.attachTarget by itself.

In order to ease the refactoring coming in bug 1506548, it would be great to reduce the number of usages of listTabs. Such cleanup would reduce quite significantly the number of callsites.

Comment 1

[Alexandre Poirot [:ochameau]]

Try run:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=213448387&revision=0e0b06f4c19352a44b9d05211dfdc1892276e1d4

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1509315 - Pass the full target form to all BrowsingContextTargetFront instances.

For now, we only pass { actor } for all tab target fronts created via DebuggerClient.attachTarget,
whereas parent process target fronts were passing the full form from RootFront.getProcess.

MozReview-Commit-ID: 1H2NxFv8glY

Comment 3

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1509315 - Use TargetFactory.forTab for creating targets in tests.

There is 4 patterns here:
* Tests using attachThreadActorForUrl like event-listeners ones. I augmented this helper method to call TargetFactory.
* Tests using attachTargetActorForUrl like debugger-statement, dbg-navigation and target-scoped-actor. Uses TargetFactory directly.
* Tests using connectDebuggerClient like navigateEvents and spaw_actor_in_parent. Uses TargetFactory directly.
* All the others, where creating DebuggerClient on their own, and calling listTabs+attachTarget. They now use TargetFactory directly.

A note about webconsole-helpers, only consoleClient attribute was used from tests using this helper.
Also, in various tests I remove the call to client.destroy, that's because shared-head will
close all the tabs/toolboxes and it should lead to target/client destruction.
Finally, debugger-statement now request the thread actor via the client instead of manual request,
it should help the refactoring to a front!

MozReview-Commit-ID: 2ah4UmSjuoi

Depends on D12730

Comment 4

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1509315 - Remove leftover from debugger head.js file.

I also removed the get root form leftover.

MozReview-Commit-ID: DxPwG9a5YAG

Depends on D12731

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1509315 - Remove unecessary calls to listTabs.

These tests are calling listTabs, but that is no longer necessary thanks to rootForm
being automatically managed within RootFront.

MozReview-Commit-ID: AmC6dTIJjiY

Depends on D12732

Comment 6

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1509315 - Refactor console attachConsole test helpers to async.

MozReview-Commit-ID: 2jIm73AiIPN

Depends on D12733

Comment 7

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1509315 - Make the console test helper use getTab instead of listTabs.

Ideally, it would use TargetFactory. But as that's mochitest chrome,
we don't have natural access to gBrowser/firefox tab.

MozReview-Commit-ID: 4nrfFZu6jAU

Depends on D12734

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce2018b0349d
Pass the full target form to all BrowsingContextTargetFront instances. r=yulia
https://hg.mozilla.org/integration/autoland/rev/18f76c415505
Use TargetFactory.forTab for creating targets in tests. r=yulia
https://hg.mozilla.org/integration/autoland/rev/322f2dd20299
Remove leftover from debugger head.js file. r=yulia
https://hg.mozilla.org/integration/autoland/rev/3eadd3d05800
Remove unecessary calls to listTabs. r=yulia
https://hg.mozilla.org/integration/autoland/rev/30bc5b0c60eb
Refactor console attachConsole test helpers to async. r=yulia
https://hg.mozilla.org/integration/autoland/rev/5e887c4ebd79
Make the console test helper use getTab instead of listTabs. r=yulia

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ce2018b0349d
https://hg.mozilla.org/mozilla-central/rev/18f76c415505
https://hg.mozilla.org/mozilla-central/rev/322f2dd20299
https://hg.mozilla.org/mozilla-central/rev/3eadd3d05800
https://hg.mozilla.org/mozilla-central/rev/30bc5b0c60eb
https://hg.mozilla.org/mozilla-central/rev/5e887c4ebd79