1509317 - Search for '@' in URL bar replaces in drop-down another searched single character

Status: RESOLVED INVALID

(Firefox :: Address Bar, defect, P2)

Description

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

Attachment: [e-mail]

[Affected versions]:
 Fx 64.0b11
 Fx 65.0a1

[Affected platforms]:
 Windows 10 x64
 Ubuntu 16.04 LTS
 Mac OS X 10.13

[Steps to reproduce]:
 1. Launch Firefox.
 2. Type in URL bar "@" a single character.
 3. Delete the "@" character and type "f" a single character.

[Expected result]:
  At step 2. display only the search engine aliases list.
  At step 3. display a list with search suggestions and at the bottom of list 
  appear two bar: "Search for f with:"
                   One-click Search Engine aliases
[Actual result]:
  At step 2. display only the search engine aliases list.
  At step 3. display a list with search suggestions and at the bottom of list 
  appear two bar: "Search for @ with:"
                   One-click Search Engine aliases
  Seems that the "@" first typed character in URL bar was blocked in drop-down, 
  "Search for @ with:" section.

[Regression range]:
  Last good: 2018.10.28
  First bad: 2018.10.29 
  Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ba284d91a4bbec997102aecdf5b39c7999b5c127&tochange=4c7772c170a1848c4e57fea0087c351fd2288859

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Hi Drew, can you please take a look at this?

Comment 2

[Drew Willcoxon :adw]

There's at least one other bug about the "Search for" label being wrong, bug 1482563.  IIRC there may be others, too.  Seems like we need an effort focusing on fixing it properly.

I'll mark this P1 for now.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

I spoke with Marco over IRC and he doesn't think this is a critical issue nor a symptom of a critical issue, just confusing. Marking as wontfix for 64 and fix-optional for 65.

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

Happy to take a patch in nightly 67, or potentially, in beta 66 for this.
Marking as fix-optional to remove it from weekly regression triage, since there is a priority assigned.

Comment 5

[Neha Kochar [:neha]]

Bulk change for all regression bugs with status-firefox67 as 'fix-optional' to be marked 'affected' for status-firefox68.

Comment 6

[Drew Willcoxon :adw]

The new one-off search buttons no longer show the search string, so I'll close this. (Still a valid bug for the old buttons though afaik.)