Closed Bug 1509317 Opened 3 years ago Closed 2 years ago

Search for '@' in URL bar replaces in drop-down another searched single character

Categories

(Firefox :: Address Bar, defect, P2)

64 Branch
defect

Tracking

()

RESOLVED INVALID
Tracking Status
firefox-esr60 --- unaffected
firefox63 --- unaffected
firefox64 --- wontfix
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- fix-optional

People

(Reporter: zstimi, Unassigned)

References

Details

(Keywords: regression)

Attachments

(1 file)

Attached image Type@asfirst.png
[Affected versions]:
 Fx 64.0b11
 Fx 65.0a1

[Affected platforms]:
 Windows 10 x64
 Ubuntu 16.04 LTS
 Mac OS X 10.13

[Steps to reproduce]:
 1. Launch Firefox.
 2. Type in URL bar "@" a single character.
 3. Delete the "@" character and type "f" a single character.

[Expected result]:
  At step 2. display only the search engine aliases list.
  At step 3. display a list with search suggestions and at the bottom of list 
  appear two bar: "Search for f with:"
                   One-click Search Engine aliases
[Actual result]:
  At step 2. display only the search engine aliases list.
  At step 3. display a list with search suggestions and at the bottom of list 
  appear two bar: "Search for @ with:"
                   One-click Search Engine aliases
  Seems that the "@" first typed character in URL bar was blocked in drop-down, 
  "Search for @ with:" section.

[Regression range]:
  Last good: 2018.10.28
  First bad: 2018.10.29 
  Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ba284d91a4bbec997102aecdf5b39c7999b5c127&tochange=4c7772c170a1848c4e57fea0087c351fd2288859
Hi Drew, can you please take a look at this?
Flags: needinfo?(adw)
There's at least one other bug about the "Search for" label being wrong, bug 1482563.  IIRC there may be others, too.  Seems like we need an effort focusing on fixing it properly.

I'll mark this P1 for now.
Flags: needinfo?(adw)
Priority: -- → P1
See Also: → 1482563
See Also: → 1360227
Priority: P1 → P2

I spoke with Marco over IRC and he doesn't think this is a critical issue nor a symptom of a critical issue, just confusing. Marking as wontfix for 64 and fix-optional for 65.

Happy to take a patch in nightly 67, or potentially, in beta 66 for this.
Marking as fix-optional to remove it from weekly regression triage, since there is a priority assigned.

Bulk change for all regression bugs with status-firefox67 as 'fix-optional' to be marked 'affected' for status-firefox68.

The new one-off search buttons no longer show the search string, so I'll close this. (Still a valid bug for the old buttons though afaik.)

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.