Closed
Bug 1509343
Opened 6 years ago
Closed 5 years ago
[wpt-sync] Sync PR 14185 - Make ReadableStream extendable
Categories
(Core :: DOM: Core & HTML, enhancement, P4)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 14185 into mozilla-central (this bug is closed when the sync is complete). PR: https://github.com/web-platform-tests/wpt/pull/14185 Details from upstream follow. Yutaka Hirano <yhirano@chromium.org> wrote: > Make ReadableStream extendable > > IDL defined ReadableStream was not extendable because it didn't use > provided |info.Holder()| as its wrapper. Instead, it creates a new > wrapper in Create functions. > > This CL solves the issue by making the constructor "custom". The custom > constructor creates a blink::ReadableStream first, then associates it > to the wrapper, and then calls the appropriate Init function. > > I will modify the IDL code generator to support the pattern, and will > remove the custom constructor in the future. > > Bug: 906476 > Change-Id: I91a7fec1cf4ee5e08704a944b0af852584d1679e > > Reviewed-on: https://chromium-review.googlesource.com/1347643 > WPT-Export-Revision: 1bfa17c916a66918b08f5b1beb2c22ca5ac0fb4e
Assignee | ||
Updated•6 years ago
|
Component: web-platform-tests → DOM
Product: Testing → Core
Assignee | ||
Comment 1•6 years ago
|
||
Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=c49b48161a0475a197862228f02ec06a66ef3d9f
Assignee | ||
Comment 2•6 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=5ae0e6ef39a2be3bc739e4906879d3f7b8b09a09
Assignee | ||
Comment 3•6 years ago
|
||
Ran 4 tests and 157 subtests OK : 4 PASS : 137 FAIL : 20 New tests that have failures or other problems: /streams/readable-streams/general.dedicatedworker.html ReadableStream: ReadableStream is extendable: FAIL /streams/readable-streams/general.html ReadableStream: ReadableStream is extendable: FAIL /streams/readable-streams/general.serviceworker.https.html ReadableStream: ReadableStream is extendable: FAIL /streams/readable-streams/general.sharedworker.html ReadableStream: ReadableStream is extendable: FAIL
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5acde4c777eb [wpt PR 14185] - Make ReadableStream extendable, a=testonly
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/mozilla-inbound/rev/a357fe0ca2e7 [wpt PR 14185] - Make ReadableStream extendable, a=testonly
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a357fe0ca2e7
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•