[wpt-sync] Sync PR 14185 - Make ReadableStream extendable

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P4
normal
RESOLVED FIXED
6 months ago
2 months ago

People

(Reporter: wptsync, Unassigned)

Tracking

unspecified
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

(Whiteboard: [wptsync downstream], )

Assignee

Description

6 months ago
Sync web-platform-tests PR 14185 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14185
Details from upstream follow.

Yutaka Hirano <yhirano@chromium.org> wrote:
>  Make ReadableStream extendable
>  
>  IDL defined ReadableStream was not extendable because it didn't use
>  provided |info.Holder()| as its wrapper. Instead, it creates a new
>  wrapper in Create functions.
>  
>  This CL solves the issue by making the constructor "custom". The custom
>  constructor creates a blink::ReadableStream first, then associates it
>  to the wrapper, and then calls the appropriate Init function.
>  
>  I will modify the IDL code generator to support the pattern, and will
>  remove the custom constructor in the future.
>  
>  Bug: 906476
>  Change-Id: I91a7fec1cf4ee5e08704a944b0af852584d1679e
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1347643
>  WPT-Export-Revision: 1bfa17c916a66918b08f5b1beb2c22ca5ac0fb4e
Assignee

Updated

6 months ago
Component: web-platform-tests → DOM
Product: Testing → Core
Assignee

Comment 3

6 months ago
Ran 4 tests and 157 subtests
OK     : 4
PASS   : 137
FAIL   : 20

New tests that have failures or other problems:
/streams/readable-streams/general.dedicatedworker.html
    ReadableStream: ReadableStream is extendable: FAIL
/streams/readable-streams/general.html
    ReadableStream: ReadableStream is extendable: FAIL
/streams/readable-streams/general.serviceworker.https.html
    ReadableStream: ReadableStream is extendable: FAIL
/streams/readable-streams/general.sharedworker.html
    ReadableStream: ReadableStream is extendable: FAIL

Comment 4

5 months ago
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5acde4c777eb
[wpt PR 14185] - Make ReadableStream extendable, a=testonly

Comment 5

5 months ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a357fe0ca2e7
[wpt PR 14185] - Make ReadableStream extendable, a=testonly

Comment 6

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a357fe0ca2e7
Status: NEW → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.