[wpt-sync] Sync PR 14190 - Worker: Add [Replaceable] to SharedWorkerGlobalScope.name

RESOLVED FIXED in Firefox 66

Status

()

Product:
Core
Component:
DOM: Workers
Type:
enhancement
Importance:
P4
normal
Status:
RESOLVED FIXED
Reported:
6 months ago
Modified:
6 months ago

People

(Reporter: wptsync, Unassigned)

Tracking

Version:
unspecified
Target:
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

(Whiteboard: [wptsync downstream],
URL
)

Assignee

Description

•
6 months ago 
Sync web-platform-tests PR 14190 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14190
Details from upstream follow.

Hiroki Nakagawa <nhiroki@chromium.org> wrote:
>  Worker: Add [Replaceable] to SharedWorkerGlobalScope.name
>  
>  The HTML spec requires SharedWorkerGlobalScope.name has [Replaceable]:
>  https://html.spec.whatwg.org/multipage/workers.html#shared-workers-and-the-sharedworkerglobalscope-interface
>  
>  This CL also fixes a test expectation of
>  wpt/workers/interfaces/SharedWorkerGlobalScope/name/setting.html. The name
>  attribute is now replaceable, so the result should be replaced. Firefox fails
>  the test because of this wrong expectation:
>  https://wpt.fyi/results/workers/interfaces/SharedWorkerGlobalScope/name/setting.html?label=stable&aligned&q=%2Fname%2Fsetting.html
>  
>  Bug: 875714
>  Change-Id: Id04ae30895a2de4a07e30f49dc1189bb9742f6b9
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1347962
>  WPT-Export-Revision: 3308bc0f708dda911db50e2638825412345cb8ea
 Assignee

Updated

•
6 months ago
Component: web-platform-tests → DOM: Workers
Product: Testing → Core
 Assignee

Comment 3

•
6 months ago 
Ran 2 tests and 7 subtests
OK     : 2
PASS   : 7

Comment 4

•
6 months ago 
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d75a74c29bb6
[wpt PR 14190] - Worker: Add [Replaceable] to SharedWorkerGlobalScope.name, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb53794d49e7
[wpt PR 14190] - Update wpt metadata, a=testonly

Comment 5

•
6 months ago 
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/902c56e2f192
[wpt PR 14190] - Worker: Add [Replaceable] to SharedWorkerGlobalScope.name, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/346e8c934436
[wpt PR 14190] - Update wpt metadata, a=testonly

Comment 6

•
6 months ago
bugherder 
https://hg.mozilla.org/mozilla-central/rev/902c56e2f192
https://hg.mozilla.org/mozilla-central/rev/346e8c934436
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.