Closed Bug 1509381 Opened 2 years ago Closed 2 years ago

Fix debug-mode page-cycles value when page-cycles < 2

Categories

(Testing :: Raptor, enhancement)

Version 3
enhancement
Not set
normal

Tracking

(firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: rwood, Assigned: rwood)

References

Details

Attachments

(1 file)

When running Raptor with --debug-mode, it limits the page-cycles to 2 max. However if the Raptor test INI has page-cycles set to less than 2 (i.e. raptor-speedometer-geckoview has page_cycles=1) debug-mode is increasing it to 2 in that case, but we don't want that.

It's because this line should be converting the first value to int first:

https://searchfox.org/mozilla-central/rev/876022232b15425bb9efde189caf747823b39567/testing/raptor/raptor/manifest.py#198
Pushed by rwood@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/db5baa0f06ca
Fix debug-mode page-cycles value when page-cycles < 2; r=Bebe
https://hg.mozilla.org/mozilla-central/rev/db5baa0f06ca
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.