1509387 - ./mach lint -l eslint doesn't look for node in ~/.mozbuild

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement, P1)

Description

[Kartikaya Gupta (email:[e-mail])]

I tried to run `./mach lint -l eslint`. It failed because it couldn't find node, and told me to run `./mach bootstrap --no-system-changes`. So I ran that, which downloaded a new clang, cbindgen, and node into my ~/.mozbuild.

Then I ran `./mach lint -l eslint` again, and again it failed with the same thing. After I ran `PATH=$PATH:$HOME/.mozbuild/node/bin` it worked. Seems to me like the mach command should look in .mozbuild for node.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

(This was on Ubuntu 16.04, in case it matters)

Comment 2

[Mark Banner (:standard8)]

This should be getting the mozbuild directory from:

https://searchfox.org/mozilla-central/rev/876022232b15425bb9efde189caf747823b39567/python/mozboot/mozboot/util.py#10

Which is called from:

https://searchfox.org/mozilla-central/rev/876022232b15425bb9efde189caf747823b39567/python/mozbuild/mozbuild/nodeutil.py#108
https://searchfox.org/mozilla-central/rev/876022232b15425bb9efde189caf747823b39567/python/mozbuild/mozbuild/nodeutil.py#21

Could you try tracing it through and see if you can see what's going wrong?

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Those bits seem to work ok. The problem is that found_exe ends up pointing to the npm binary at /home/kats/.mozbuild/node/bin/npm, and the very first line of that is "#!/usr/bin/env node". So when we run said npm binary to check the version, it fails to run because there's no `node` binary on the PATH and /usr/bin/env won't find it.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Here's what I see at the top of the output with a printout that I added:

$ ./mach lint -l eslint gfx/wr/
found_exe: nodejs /usr/bin/nodejs
found_exe: node /usr/bin/nodejs
found_exe: npm /home/kats/.mozbuild/node/bin/npm
/usr/bin/env: ‘node’: No such file or directory
Could not find npm executable later than 5.6.

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 1509387 - When setting up ESLint, call npm via node so that node doesn't need to be in the path.

Comment 6

[Mark Banner (:standard8)]

Thank you for that, very helpful. Looks like we need to wrap the calls to npm. We're already doing this for eslint itself, but obviously need to do npm as well.

Could you try the patch I've just attached? I think that will fix it.

If you've already worked around it, then trying this should be enough (as long as node isn't in your path):

- Remove <topsrcdir>/node_modules
- ./mach eslint --setup

Comment 7

[Kartikaya Gupta (email:[e-mail])]

The patch seems to work, thanks!

Comment 8

[Mark Banner (:standard8)]

Great, thanks for checking, I'll get that reviewed :-)

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f851c3e82c2b
When setting up ESLint, call npm via node so that node doesn't need to be in the path. r=ahal

Comment 10

[Andreea Pavel [:apavel]]

Backed out for build bustages

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=f851c3e82c2bad0afd8a2460245c9054c908e79f

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=214074746&repo=autoland&lineNumber=1172

Backout: https://hg.mozilla.org/integration/autoland/rev/02c470cc3f8dcd686cdcda402a514d3c8501ce89

Comment 11

[Mark Banner (:standard8)]

Oops:

    def check_executable_version(exe, wrap_call_with_node=True):

that default should have been False. That could quite easily cause a continuous loop.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a177ba2ca668
When setting up ESLint, call npm via node so that node doesn't need to be in the path. r=ahal

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a177ba2ca668