1509453 - dav1d: enable ASM builds on the decoder

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P2)

Description

[Alex Chronopoulos [:achronop]]

The 1st version of dav1d decoder, introduced with Bug 1493400, does not build the .asm files. That would require to support NASM in our build system. We have that to some extend now with Bug 1501796.

Testing locally with ASM on resulted in much faster decoding and smoother result.

Comment 1

[Alex Chronopoulos [:achronop]]

I get try build errors which look like NASM integration problem, if you can have a look
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1490a3d2e342fc21f924568259a4c1cea5c031ee

Comment 2

[Alex Chronopoulos [:achronop]]

Pulling from central solved the above issue but build failed again on `third_party/dav1d/src/x86/ipred.asm`. 
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8262d7e92297d8c4a4f0d6c84691b996b89b26e4&selectedJob=214455001

Comment 3

[Alex Chronopoulos [:achronop]]

This is the same try run including the patch from Bug 1511223.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d2eedd183d028ce858b4b12fcb51ebe846b2895c

Comment 4

[Alex Chronopoulos [:achronop]]

Similar to above using the latest patch from Bug 1511223.
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=215670285&revision=b8cd27b9190fb2b09ec5054ba9648278746c91c0

Comment 5

[Alex Chronopoulos [:achronop]]

This is the latest run. Linux looks good, I am working on the crash in OSX and to enable ASM on windows (x86_64 platform). On android asm remains disabled.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=734ae2afaef781fce209c2a758dc832734e77afa

Comment 6

[Alex Chronopoulos [:achronop]]

This is a the latest run after pulling from upsteam (commit 12dc2be).
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=216999683&revision=b77f1a5b8ea87c82acccf0f60598862da4ef5d80

Comment 7

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1509453 - Build dav1d's assembly files. r?TD-Linux

Comment 8

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1509453 - Update dav1d from upstream to b53a99b9. r?TD-Linux

Comment 9

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1509453 - Update build files to latest dav1d import. r?TD-Linux

Comment 10

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1509453 - Consolidate dav1d config headers to a single one. r?TD-Linux

Comment 11

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f963aa5f793cb6934f0162cf50bdace5373026d2

Comment 12

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec762f2be994642e56ef9244b015060b57944e94

Comment 13

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e80e495f0d4218725be1d8a1fab2902001ec748

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5dca7c22f8d5
Build dav1d's assembly files. r=TD-Linux
https://hg.mozilla.org/integration/autoland/rev/7cef042c6b82
Update dav1d from upstream to b53a99b9. r=TD-Linux
https://hg.mozilla.org/integration/autoland/rev/e0908cd28fb6
Update build files to latest dav1d import. r=TD-Linux
https://hg.mozilla.org/integration/autoland/rev/8d21d98de1ac
Consolidate dav1d config headers to a single one. r=TD-Linux

Comment 15

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/5dca7c22f8d5
https://hg.mozilla.org/mozilla-central/rev/7cef042c6b82
https://hg.mozilla.org/mozilla-central/rev/e0908cd28fb6
https://hg.mozilla.org/mozilla-central/rev/8d21d98de1ac