Highlighter toggle in wrong state when layout panel hasn't been opened

VERIFIED FIXED in Firefox 65

Status

defect
P3
normal
VERIFIED FIXED
5 months ago
3 months ago

People

(Reporter: mbalfanz, Assigned: gl)

Tracking

65 Branch
Firefox 65

Firefox Tracking Flags

(firefox65 verified)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 months ago
Posted video flex-toggle.mp4
STR:
- open a website containing flexbox elements
- open the inspector, without the layout panel being on by default
- highlight a flex container through the rules panel
- switch to the layout panel

ER:
- the toggle for the flex highlighter should be enabled

AR:
- the toggle for the flex highlighter is disabled


See video attached
(Assignee)

Updated

5 months ago
Assignee: nobody → gl
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 months ago
Attachment #9028165 - Flags: review?(pbrosset)
Attachment #9028165 - Flags: review?(pbrosset) → review+

Comment 2

5 months ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cfb51d413370
Get the flexbox highlighter state if the highlighter is ready in the flexbox panel. r=pbro
(Assignee)

Updated

5 months ago
Flags: needinfo?(gl)

Comment 4

5 months ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0f0794724871
Get the flexbox highlighter state if the highlighter is ready in the flexbox panel. r=pbro

Comment 6

5 months ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a7d0cec00a3
Get the flexbox highlighter state if the highlighter is ready in the flexbox panel. r=pbro

Comment 7

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7a7d0cec00a3
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
(Assignee)

Updated

5 months ago
Flags: needinfo?(gl)
Flags: qe-verify+

I reproduced this issue using 65.0a1(2018-11-23), on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx 65.0b11 on Windows 10 x64, macOS 10.13 and Ubuntu 16.04 LTS.
Cheers!

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.