Closed Bug 1509460 Opened 11 months ago Closed 10 months ago

disable/re-enable and delete/bring back should not bring the flexbox highlighter back

Categories

(DevTools :: Inspector, enhancement, P2)

enhancement

Tracking

(firefox65 fixed)

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: miker, Assigned: miker)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Martin and Gabe agreed on the following "disable/re-enable and delete/bring back should not bring the flexbox highlighter back." The reasoning for this is to bring consistency across all the highlighters since the shape editor already has this behaviour.

Unfortunately, the solution is no longer as easy, but this is a good opportunity to work on HighlightersOverlay.js.

We should add a new event handler for "display-change" from the Walker in HighlightersOverlay.js. See https://searchfox.org/mozilla-central/source/devtools/client/inspector/markup/markup.js#120 for an example. From there we should work on freeing the grid and flexbox highlighter shown for the node that has its display changed. We will also need unit tests.

This will also fix a bug for the multigrid highlighter. If you go to https://gridbyexample.com/learn/, and turn on highlighting for 2 sections and 1 h2, and then turn off/delete "display: grid" for the h2, you will see we can't toggle on a third grid.
Assignee: nobody → mratcliffe
Status: NEW → ASSIGNED
This is a WIP patch that frees up the flexbox highlighter.

TODO: The same for the grid highlighter.
Attachment #9027231 - Attachment description: Bug 1509460 - Disable / re-enable and delete/bring back should not bring the flexbox highlighter back → Bug 1509460 - Disable / re-enable and delete/bring back should not bring the flexbox highlighter back r?gl!
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/863de59a4842
Disable / re-enable and delete/bring back should not bring the flexbox highlighter back r=gl
https://hg.mozilla.org/mozilla-central/rev/863de59a4842
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.