Closed Bug 1509469 Opened 9 months ago Closed 9 months ago

Remove unused ContentAreaUtils.ioService

Categories

(Toolkit :: General, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: dao, Assigned: hrushikeshcoc, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=js])

Attachments

(1 file)

The comment says we kept this "for backwards compatibility", but this can't anymore be accessed from external code such as add-ons:

https://searchfox.org/mozilla-central/rev/876022232b15425bb9efde189caf747823b39567/toolkit/content/contentAreaUtils.js#22-27
I would like to take this up.
(In reply to Hrushikesh Bodas from comment #1)
> I would like to take this up.

Go ahead! Let me know if you have questions.
I have a doubt on this... Where do I get the code from? Github says that the repository is retired.
@Hrushikesh Bodas : Are you still working on this?
Yea I am still working on this bug. I'm wait for a stable internet connection which I will get by today evening.
@Dão Gottwald Which repo should i clone in mercurial? Also how can i contact you on IRC?
::dao I have removed the lines and made local changes to the repository.
::dao I am trying to push the changes to the repo with the error authorization failed. I read your message on How to Submit a patch.
Also please assign this bug to me
(In reply to Hrushikesh Bodas from comment #9)
> ::dao I am trying to push the changes to the repo with the error
> authorization failed. I read your message on How to Submit a patch.

How exactly did you try to push the patch?
Assignee: nobody → hrushikeshcoc
Priority: -- → P5
::dao there was an error in my configuration of arcainst. I'm still working on getting the setup right.
I have made the changes and after a troubling setup, applied for review... on phabricator mozilla, it shows that reviewers have not been specified.
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cec394267904
Remove unused ContentAreaUtils.ioService r=dao
https://hg.mozilla.org/mozilla-central/rev/cec394267904
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.