Closed Bug 1509470 Opened 6 years ago Closed 5 years ago

Add license for react-router-dom

Categories

(DevTools :: about:debugging, enhancement, P1)

Product:
DevTools
Component:
about:debugging
Type:
enhancement

Tracking

(firefox66 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 66
Tracking Flags:
Tracking Status
firefox66 --- fixed

People

(Reporter: ladybenko, Assigned: ladybenko)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1509470 - Add license for react-router-dom. r=jdescottes,mhoye
47 bytes, text/x-phabricator-request
Details | Review 
We must add the react-router-dom library (in `devtools/client/shared/vendor/`) license file (it's MIT): https://github.com/ReactTraining/react-router/blob/master/LICENSE
Who should we ping to check the license?
Blocks: remote-debugging-ng-m2
No longer blocks: remote-debugging-ng
Priority: -- → P2
I think it's Mike Hoye? Hi Mike! Is it you?
Flags: needinfo?(mhoye)
It is me! And the MIT license is a permitted license, so go for it.

You should add a copy to the bbout:license file per the adjacent examples - there are a few React-related licenses in there already, and Devtools licenses still go in the same place as other Mozilla licenses, right? - then flag me to review it. I'll be able to turn it around quickly.
Flags: needinfo?(mhoye)
Assignee: nobody → balbeza
Status: NEW → ASSIGNED
Priority: P2 → P1
Pushed by balbeza@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f9ae7fd32a86
Add license for react-router-dom. r=jdescottes,mhoye
https://hg.mozilla.org/mozilla-central/rev/f9ae7fd32a86
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: