Closed Bug 1509483 Opened 11 months ago Closed 11 months ago

Dark theme: Tasks titles are a black font on a black background and thus not readable

Categories

(Calendar :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
6.2.3.3

People

(Reporter: r.pausch, Assigned: Paenglab)

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:63.0) Gecko/20100101 Firefox/63.0

Steps to reproduce:

I switched to the "Dark" theme of Thunderbird and created a task in the "Tasks" manager tab. In the box below, where the user can add a description, there is also a box which contains the "title" and "status". Their content is not readable. 

System information: 
MacOS 10.14.1 (in dark mode)
Thunderbird 60.3.1 (64-bit)


Actual results:

Both the "title" and "status" content are not readable because both font color and background color are black - see the attached image. However both the words "title" and "status" are readable due to their lighter font color. 


Expected results:

The font color (or the background color) should not be the same. Using a grey font (x)or background would enable readability.
Assignee: nobody → richard.marti
Status: UNCONFIRMED → NEW
Component: Theme → General
Ever confirmed: true
Product: Thunderbird → Calendar
Version: 60 → unspecified
The dark background comes with bug 1504190. Until then it is light.
Unfortunately the details pane didn't had a background colour on macOS and the window background was shown when the window is not inactive.

I hope we can land this patch in the next beta and ESR.
Attachment #9027235 - Flags: review?(philipp)
Attachment #9027235 - Flags: approval-calendar-esr?(philipp)
Attachment #9027235 - Flags: approval-calendar-beta?(philipp)
Comment on attachment 9027235 [details] [diff] [review]
1509483-task-details-background-color.patch

Review of attachment 9027235 [details] [diff] [review]:
-----------------------------------------------------------------

If we are setting a background color, we should also be setting a color, to avoid contrast issues. Can you make sure to set one before you push?
Attachment #9027235 - Flags: review?(philipp)
Attachment #9027235 - Flags: review+
Attachment #9027235 - Flags: approval-calendar-esr?(philipp)
Attachment #9027235 - Flags: approval-calendar-esr+
Attachment #9027235 - Flags: approval-calendar-beta?(philipp)
Attachment #9027235 - Flags: approval-calendar-beta+
Keywords: checkin-needed
Keywords: checkin-needed
(In reply to Philipp Kewisch [:Fallen] [:📆] from comment #2)
> Comment on attachment 9027235 [details] [diff] [review]
> 1509483-task-details-background-color.patch
> 
> Review of attachment 9027235 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> If we are setting a background color, we should also be setting a color, to
> avoid contrast issues. Can you make sure to set one before you push?

The text colour is set here: https://searchfox.org/comm-central/source/mail/themes/osx/mail/messageHeader.css#13
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/debcebde19f1
Set a background color for #calendar-task-details-container on macOS. r=philipp
Status: NEW → RESOLVED
Closed: 11 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 6.7
TB 60.4 ESR, Cal 6.2.4:
https://hg.mozilla.org/releases/comm-esr60/rev/04fee377d47e89dedeb57f3099f13f3f4772aaf4
Target Milestone: 6.7 → 6.2.4
Comment on attachment 9027235 [details] [diff] [review]
1509483-task-details-background-color.patch

Landed on TB 65, no further TB 64 beta.
Attachment #9027235 - Flags: approval-calendar-beta+

Should be not existing target milestone 6.2.3.3, setting to 6.2.3.1.

Target Milestone: 6.2.4 → 6.2.3.1
Target Milestone: 6.2.3.1 → 6.2.3.3
You need to log in before you can comment on or make changes to this bug.