15095 - clickCount not computed correctly on Win32 (never > 2)

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Eli Goldberg]

* TITLE/SUMMARY
[PP] Triple-clicking doesn't select anything on Win32, Linux

* STEPS TO REPRODUCE
0) Launch Apprunner
1) View any web page. (I was using http://slip/projects/marvin/selection/triple-
click-text/triple-click-text.html)
2) From within the browser, attempt to triple-click a line of text.

* RESULT
 - What happened

On Mac OS, the text is selected. On Win32 and Linux, no selection takes place.

(Within the Win32 editor, an editing caret is placed, but no text selection takes
place. On Mac OS, it works.)

 - What was expected

Triple-click gestures should select a line of text. (roughly speaking; platform
UI guidelines clarifies corner cases, as does the triple-click-text test case
cited above.)

* REGRESSION

 - Occurs On
        Win32 Apprunner (1999092808 optimized build [NT 4, Service Pack 5])
        Linux Apprunner (1999092708 optimized build)

 - Doesn't Occur On
        Mac OS Apprunner (1999092808 optimized build)


* CONFIGURATIONS TESTED

- [Mac] Beige Power Mac G3 (266 MHz PowerPC 750), 96 MB RAM (VM on; 1 MB of VM
used), 1024x768 (Thousands of Colors), Mac OS 8.6

- [Win32] Vectra VL (233 MHz P2), 96 MB RAM, 800x600 (True Color), NT 4.0 SP5.

- [Linux] Vectra VL (266 MHz P2), 96 MB RAM. Red Hat Linux 6.0 (GNOME).

Comment 1

[Kathleen :Brade]

I believe that this has been addressed on Linux.  Changing Summary to reflect
that.

Eli--please correct summary again if I am incorrect.

This bug should be reassigned to someone (rods?) since it isn't a selection
problem but a windows-specific problem.

Comment 2

[Akkana Peck]

It's working fine for me on Linux today (though Eli should probably also verify
that).

Comment 3

[Eli Goldberg]

[will confirm when M10 goes out the door; currently using M10 builds...]

Comment 4

[mjudge]

if someday the back end gets a tripple click on windows. this will be fixed. I
am not going to go fix it since this isnt a regression. most win32 apps dont do
tripple click.  Again the code is XP and if we get a message of a tripple click
from the event code, this will work. if you want, reassign it to someone doing
windows event code..

Comment 5

[Eli Goldberg]

Changing to RESOLVED/LATER, per mjudge's comments.

Comment 6

[Eli Goldberg]

Verified fixed in Linux on this morning's build. Verifying as LATER per mjudge's
comments.

Comment 7

[Kathleen :Brade]

reopen bug; this bug is for clickCount getting updated properly on Windows.
Probably the code should have been written xp but that should probably be
optimized/unified in another release.

Changing summary to match mjudge's findings.

I can imagine that other apps / utilities will want an accurate clickCount so I
think we should fix this bug.

Comment 8

[Kathleen :Brade]

btw, this can probably wait until after beta 1

Comment 9

[Peter Trudelle]

reassigning to rods, per hyatt.

Comment 10

[Michael Lowe]

See nsMacEventHandler.cpp for how this can be handled.   Not too dificult to
replicate in Windows.

Comment 11

[rods (gone)]

changed to M14

Comment 12

[rods (gone)]

moving to M15

Comment 13

[rods (gone)]

mass-move to M16

Comment 14

[Kathleen :Brade]

*** Bug 37373 has been marked as a duplicate of this bug. ***

Comment 15

[rods (gone)]

I have no idea how to get three clicks out of windows. Help!

Comment 16

[Akkana Peck]

Rod, scroll up a little to see Michael Lowe's pointer to the file where Mac
implemented it.

Comment 17

[Kathleen :Brade]

rods--The MacOS doesn't give programmers double-click or triple-click messages; 
just mousedown and mouseup.  You may want to look at the Macintosh event code.  
It has a counter and keeps track of how many consecutive clicks it gets so it can 
send the dom the proper number of clicks.  It really should be pretty easy.

Comment 18

[rods (gone)]

fix is in my tree

Comment 19

[rods (gone)]

fixed

Comment 20

[Akkana Peck]

Verifying should be easy at a user level: triple-click on a line, and see if a
line (or, at least, something more than a word, since there are bugs with line
selection) gets selected.

Comment 21

[Eli Goldberg]

Yup. That's why I marked it with a 'verifyme' keyword, since it was clearly 
documented enough for net.community people to give it a shot. see ya.

Comment 22

[Asa Dotzler [:asa]]

verified with 071108 mozilla build on NT 4 
Tripple click correctly selects the line.  This also works in forms (bug 37373)