Closed
Bug 1509555
Opened 6 years ago
Closed 6 years ago
Remove all fastblock code
Categories
(Firefox :: Protections UI, enhancement)
Firefox
Protections UI
Tracking
()
RESOLVED
FIXED
Firefox 65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(5 files)
Examples like bug 1509340 show that keeping the fastblock code around is only costing us in terms of a stream of regressions that we need to fix (and also, added development time to deal with the existing code, which is no longer used for anything.)
It is also very confusing to have this feature which doesn't have any UI any more but can still be turned on, probably accidentally. It's time to remove it. I checked with pdol, in case we want to resurrect a new version based on the same idea we can always bring the code back from version control.
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Depends on D12828
Assignee | ||
Comment 3•6 years ago
|
||
Depends on D12829
Assignee | ||
Comment 4•6 years ago
|
||
Depends on D12830
Assignee | ||
Comment 5•6 years ago
|
||
Depends on D12831
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e01c587ecd1d
Part 1: Remove the telemetry probe for measuring the rate at which popular analytics providers get blocked by fastblock r=baku,valentin
https://hg.mozilla.org/integration/autoland/rev/dd23df519c7e
Part 2: Remove the core fastblock code r=valentin
https://hg.mozilla.org/integration/autoland/rev/4374fb0c2335
Part 3: Remove reporting of tracker statistics to docshell which was added for fastblock r=valentin,baku
https://hg.mozilla.org/integration/autoland/rev/52afd894ca9e
Part 4: Remove nsIWebProgressListener::STATE_BLOCKED_SLOW_TRACKING_CONTENT r=baku
https://hg.mozilla.org/integration/autoland/rev/9555f6d408f1
Part 5: Remove fastblock from tests r=baku
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e01c587ecd1d
https://hg.mozilla.org/mozilla-central/rev/dd23df519c7e
https://hg.mozilla.org/mozilla-central/rev/4374fb0c2335
https://hg.mozilla.org/mozilla-central/rev/52afd894ca9e
https://hg.mozilla.org/mozilla-central/rev/9555f6d408f1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in
before you can comment on or make changes to this bug.
Description
•