Closed Bug 1509558 Opened 11 months ago Closed 11 months ago

Trackers sub-panel looks wrong in RTL mode

Categories

(Firefox :: Site Identity, defect, P2)

defect

Tracking

()

VERIFIED FIXED
Firefox 65
Tracking Status
firefox65 --- verified

People

(Reporter: ehsan, Assigned: ewright)

References

Details

(Keywords: rtl, Whiteboard: [privacy65])

Attachments

(2 files)

Attached image Screenshot
See the screenshot.

I can spot at least two problems with a cursory look:

  * The arrow on the main button is pointing to right.  It should be pointing to left.
  * The animation of the panel seems to flow in the wrong direction?  It gives the impression that the panel fades in and out instead of animating in and out.
Weird, the arrow has a rule for RTL and when I tested it worked for me. I don't think we can trivially fix the panel flow, that's probably worth a separate bug in Firefox::Menus.
Priority: -- → P2
Whiteboard: [privacy65]
So, I tried it again and it seems to be a matter of the RTL CSS selector not updating when I switch the uidirection pref. After a restart everything looked fine. Can you confirm, Ehsan?
Flags: needinfo?(ehsan)
(In reply to Johann Hofmann [:johannh] from comment #2)
> So, I tried it again and it seems to be a matter of the RTL CSS selector not
> updating when I switch the uidirection pref. After a restart everything
> looked fine. Can you confirm, Ehsan?

This was an error in my testing it seems.  The only issue here is the problem that Erica's patch is fixing in comment 3 (thanks, Erica!)
Flags: needinfo?(ehsan)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/74216c81fc8d
Trackers sub-panel category menu is correct in RTL mode. r=Ehsan
https://hg.mozilla.org/mozilla-central/rev/74216c81fc8d
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Assignee: nobody → ewright
Depends on: 1510959
Verified - Fixed on latest Nightly 65.0a1 (2018-11-28) (64-bit) on Windows 7/10 x64, Ubuntu 18.04. and Mac OS 10.14.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.