1509558 - Trackers sub-panel looks wrong in RTL mode

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect, P2)

Description

[(no longer active)]

Attachment: Screenshot

See the screenshot.

I can spot at least two problems with a cursory look:

  * The arrow on the main button is pointing to right.  It should be pointing to left.
  * The animation of the panel seems to flow in the wrong direction?  It gives the impression that the panel fades in and out instead of animating in and out.

Comment 1

[Johann Hofmann [:johannh]]

Weird, the arrow has a rule for RTL and when I tested it worked for me. I don't think we can trivially fix the panel flow, that's probably worth a separate bug in Firefox::Menus.

Comment 2

[Johann Hofmann [:johannh]]

So, I tried it again and it seems to be a matter of the RTL CSS selector not updating when I switch the uidirection pref. After a restart everything looked fine. Can you confirm, Ehsan?

Comment 3

[Erica Wright [:ewright]]

Attachment: Bug 1509558 - Trackers sub-panel category menu is correct in RTL mode.

Comment 4

[(no longer active)]

(In reply to Johann Hofmann [:johannh] from comment #2)
> So, I tried it again and it seems to be a matter of the RTL CSS selector not
> updating when I switch the uidirection pref. After a restart everything
> looked fine. Can you confirm, Ehsan?

This was an error in my testing it seems.  The only issue here is the problem that Erica's patch is fixing in comment 3 (thanks, Erica!)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/74216c81fc8d
Trackers sub-panel category menu is correct in RTL mode. r=Ehsan

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/74216c81fc8d

Comment 7

[Timea Cernea [:tbabos][inactive]]

Verified - Fixed on latest Nightly 65.0a1 (2018-11-28) (64-bit) on Windows 7/10 x64, Ubuntu 18.04. and Mac OS 10.14.