Closed Bug 1509571 Opened 1 year ago Closed 1 year ago

Profiling is broken for sessionrestore_no_auto_restore

Categories

(Testing :: Talos, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(1 file)

I guess I forgot to check this variant when fixing bug 1504133. We're not ensuring that TalosParentProfiler exists, nor dumping the profile correctly when not restoring the session automatically.

Patch coming up.
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f78fcb8e46d4
Fix profiling for the sessionrestore_no_auto_restore Talos test. r=aswan
https://hg.mozilla.org/mozilla-central/rev/f78fcb8e46d4
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
== Change summary for alert #17863 (as of Wed, 28 Nov 2018 12:47:59 GMT) ==

Improvements:

 10%  sessionrestore_no_auto_restore windows10-64 pgo e10s stylo        352.58 -> 316.50
 10%  sessionrestore_no_auto_restore linux64 pgo e10s stylo             408.54 -> 368.08
  8%  sessionrestore_no_auto_restore windows7-32 pgo e10s stylo         350.67 -> 322.58
  8%  sessionrestore_no_auto_restore windows10-64-qr opt e10s stylo     381.29 -> 352.17
  7%  sessionrestore_no_auto_restore linux64 opt e10s stylo             431.58 -> 399.75
  7%  sessionrestore_no_auto_restore windows7-32 opt e10s stylo         373.46 -> 348.17
  5%  sessionrestore_no_auto_restore windows10-64 opt e10s stylo        367.92 -> 350.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=17863
Depends on: 1511714
You need to log in before you can comment on or make changes to this bug.