1509572 - Cleanup small pieces of Gradle integration

Status: RESOLVED FIXED

(Firefox Build System :: Android Studio and Gradle Integration, enhancement)

Description

[Nick Alexander :nalexander [he/him]]

This is just a ticket to land some Pre: parts for Bug 1509539.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1509572 - Part 1: Bump Gradle wrapper to 4.10.2; decouple script from Gradle version. r?snorp

This depends on there being only one Gradle version downloaded, but I
think that is safe enough.

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1509572 - Part 2: Don't pass --console=plain and --continue through to Gradle. r?snorp

--console=plain is critical in automation, but it's not always helpful
locally.  Let's try without it for a while.

--continue tries to build additional tasks even after the first
failing task.  It can be useful in automation ('cuz you might see more
errors) but it can also be confusing (because the build fails but
produces additional output).  Let's try without it, too.

Depends on D12790

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1509572 - Part 3: Don't dump R.txt for every build. r?snorp

This has never been as useful as anticipated: we really aren't seeing
resource mismatches in the wild that need diagnostic aids.

Depends on D12791

Comment 4

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1509572 - Part 4: Make `geckoview:generateSDKBindings` work without arguments. r?snorp

I'm not sure how this ever worked in the `android-gradle-dependencies`
task -- it must have been because of `--continue`.

Depends on D12792

Comment 5

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1509572 - Part 5: Depend on bundle, not assemble. r?snorp

This will be exploited later, when we start making the
`withGeckoBinaries` switch conditional on the tasks that Gradle is
going to execute.

Depends on D12793

Comment 6

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1509572 - Part 6: Don't always generate annotations from Gradle. r?snorp

Before, we always ran the "generate JNI wrappers" command and had the
command be smart about updating the output.  Now we move the smarts to
the Gradle side to streamline the build.

Depends on D12794

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4087e8ea340
Part 1: Bump Gradle wrapper to 4.10.2; decouple script from Gradle version. r=snorp
https://hg.mozilla.org/integration/autoland/rev/bd0729ff0bbc
Part 2: Don't pass --console=plain and --continue through to Gradle. r=snorp
https://hg.mozilla.org/integration/autoland/rev/bc6911d14ae0
Part 3: Don't dump R.txt for every build. r=snorp
https://hg.mozilla.org/integration/autoland/rev/122d6f1a1136
Part 4: Make `geckoview:generateSDKBindings` work without arguments. r=snorp
https://hg.mozilla.org/integration/autoland/rev/f6653c7d2967
Part 5: Depend on bundle, not assemble. r=snorp
https://hg.mozilla.org/integration/autoland/rev/9f6a7e664cef
Part 6: Don't always generate annotations from Gradle. r=snorp

Comment 8

[Dorel Luca [:dluca]]

Backed out 6 changesets (bug 1509572) for linting failure. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=213957496&repo=autoland&lineNumber=272

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=9f6a7e664cef95703e629aa3fd02cd6a5b014f54

Backout:
https://hg.mozilla.org/integration/autoland/rev/79ae8ec996e64730196a994093f3ff8bb4af1384

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c145e1dbd4d
Part 1: Bump Gradle wrapper to 4.10.2; decouple script from Gradle version. r=snorp
https://hg.mozilla.org/integration/autoland/rev/f84f04e601e4
Part 2: Don't pass --console=plain and --continue through to Gradle. r=snorp
https://hg.mozilla.org/integration/autoland/rev/a748fb34ae07
Part 3: Don't dump R.txt for every build. r=snorp
https://hg.mozilla.org/integration/autoland/rev/851fd4b655df
Part 4: Make `geckoview:generateSDKBindings` work without arguments. r=snorp
https://hg.mozilla.org/integration/autoland/rev/d8102b5a209a
Part 5: Depend on bundle, not assemble. r=snorp
https://hg.mozilla.org/integration/autoland/rev/8d0de38dc4c8
Part 6: Don't always generate annotations from Gradle. r=snorp

Comment 10

[Nick Alexander :nalexander [he/him]]

(In reply to Dorel Luca [:dluca] from comment #8)
> Backed out 6 changesets (bug 1509572) for linting failure. CLOSED TREE
> 
> Log:
> https://treeherder.mozilla.org/logviewer.
> html#?job_id=213957496&repo=autoland&lineNumber=272
> 
> Push with failures:
> https://treeherder.mozilla.org/#/
> jobs?repo=autoland&group_state=expanded&revision=9f6a7e664cef95703e629aa3fd02
> cd6a5b014f54
> 
> Backout:
> https://hg.mozilla.org/integration/autoland/rev/
> 79ae8ec996e64730196a994093f3ff8bb4af1384

Thanks, Dorel.  I folded a fix into a future commit; back-ported and relanded.  Fingers crossed!

Comment 11

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/7c145e1dbd4d
https://hg.mozilla.org/mozilla-central/rev/f84f04e601e4
https://hg.mozilla.org/mozilla-central/rev/a748fb34ae07
https://hg.mozilla.org/mozilla-central/rev/851fd4b655df
https://hg.mozilla.org/mozilla-central/rev/d8102b5a209a
https://hg.mozilla.org/mozilla-central/rev/8d0de38dc4c8