Crash in OOM | large | NS_ABORT_OOM | nsIFrame::MarkNeedsDisplayItemRebuild

RESOLVED FIXED in Firefox 65

Status

()

defect
P2
critical
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: philipp, Assigned: miko)

Tracking

(Blocks 1 bug, {crash, regression})

64 Branch
mozilla65
All
Windows
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox63 unaffected, firefox64 wontfix, firefox65 fixed)

Details

(crash signature)

Attachments

(2 attachments)

Reporter

Description

6 months ago
This bug was filed from the Socorro interface and is
report bp-1fdcaa54-94cd-483a-9461-9af340181123.
=============================================================

Top 10 frames of crashing thread:

0 xul.dll NS_ABORT_OOM xpcom/base/nsDebugImpl.cpp:628
1 xul.dll nsIFrame::MarkNeedsDisplayItemRebuild layout/generic/nsFrame.cpp:1048
2 xul.dll nsIFrame::SetSize layout/generic/nsIFrame.h:1074
3 xul.dll void nsBlockFrame::ReflowBlockFrame layout/generic/nsBlockFrame.cpp:3716
4 xul.dll void nsBlockFrame::ReflowDirtyLines layout/generic/nsBlockFrame.cpp:2460
5 xul.dll nsBlockFrame::Reflow layout/generic/nsBlockFrame.cpp:1294
6 xul.dll void nsBlockReflowContext::ReflowBlock layout/generic/nsBlockReflowContext.cpp:309
7 xul.dll void nsBlockFrame::ReflowBlockFrame layout/generic/nsBlockFrame.cpp:3573
8 xul.dll void nsBlockFrame::ReflowDirtyLines layout/generic/nsBlockFrame.cpp:2460
9 xul.dll nsBlockFrame::Reflow layout/generic/nsBlockFrame.cpp:1294

=============================================================

this oom signature is newly showing up from installations on windows in firefox 64. could this be related to the work in
Flags: needinfo?(mikokm)
Assignee

Comment 1

6 months ago
The changes for bug 1488599 removed the check for modified frames count, which might have caused this. I am looking into this.
Assignee: nobody → mikokm
Status: NEW → ASSIGNED
Flags: needinfo?(mikokm)
Priority: -- → P2

Comment 4

6 months ago
Pushed by mikokm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6a516d21eae6
Part 1: Do not mark frames modified after the rebuild limit has been reached r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/57816e067da5
Part 2: Do not call MarkNeedsDisplayItemRebuild(), when GetDependentFrame() == Frame() r=mattwoodrow

Comment 5

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6a516d21eae6
https://hg.mozilla.org/mozilla-central/rev/57816e067da5
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
No crashes on Beta65 so far.
Crash volume on 64 release doesn't seem too worrying so far, I'll call this wontfix.
You need to log in before you can comment on or make changes to this bug.