1509591 - Eliminate mIPCOpen in favor of IProtocol::CanSend()

Status: NEW

(Core :: IPC, enhancement, P3)

Description

[Nika Layzell [:nika] (ni? for response)]

IProtocol should have an IPCOpen() method which returns 'true' if it is possible to send messages over the actor, acting in the same way as the many, many mIPCOpen implementations made with ActorDestroy.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1509591 - Part 1: Maintain an IPCOpen variable in IProtocol,

Previously there were many different inconsistent implementations of this
variable across many different actors. This adds a unified implementation of
this variable inside of IProtocol.

Depends on D12955

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1509591 - Part 2: Remove now-unnecessary mIPCOpen variable,

This should eliminate most variables which can be replaced with IPCOpen().

Depends on D12956

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/123b5d5a3637
Part 1: Maintain an IPCOpen variable in IProtocol, r=mccr8
https://hg.mozilla.org/integration/mozilla-inbound/rev/6494840edc17
Part 2: Remove now-unnecessary mIPCOpen variable, r=mccr8

Comment 4

[Arthur Iakab [arthur_iakab]]

Backed out 13 changesets (bug 1500948, bug 1509362, bug 1509591, bug 1448426, bug 1500949, bug 1487249, bug 1509930, bug 1500950, bug 1500944) for causing crashes and assertion failures on PBackgroundParent.cpp:696 CLOSED TREE

Backout revision https://hg.mozilla.org/integration/mozilla-inbound/rev/9bfe29337ffe3d93cd060077e2e999e72bb9b7cf

Failed push https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=214255312&revision=c3fe435e473a463fbc22d4afa531bdedb757079c

Failure logs: https://treeherder.mozilla.org/logviewer.html#?job_id=214255312&repo=mozilla-inbound
              https://treeherder.mozilla.org/logviewer.html#?job_id=214255794&repo=mozilla-inbound
              https://treeherder.mozilla.org/logviewer.html#?job_id=214249038&repo=mozilla-inbound
              https://treeherder.mozilla.org/logviewer.html#?job_id=214249630&repo=mozilla-inbound

:Nika Layzell Could you please take a look?

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1509591 - Part 3: Set mIPCOpen more reliably and consistently,

Comment 6

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1509591 - Part 4: Remove mIPCOpen and merge with mLivenessState,

Comment 7

[Nika Layzell [:nika] (ni? for response)]

clearing ni? for when I get back to this in the future.