Open
Bug 1509591
Opened 4 years ago
Updated 4 months ago
Eliminate mIPCOpen in favor of IProtocol::CanSend()
Categories
(Core :: IPC, enhancement, P3)
Core
IPC
Tracking
()
NEW
People
(Reporter: nika, Unassigned)
References
(Blocks 2 open bugs)
Details
Attachments
(2 files, 2 obsolete files)
IProtocol should have an IPCOpen() method which returns 'true' if it is possible to send messages over the actor, acting in the same way as the many, many mIPCOpen implementations made with ActorDestroy.
Reporter | ||
Updated•4 years ago
|
Priority: -- → P3
Reporter | ||
Comment 1•4 years ago
|
||
Previously there were many different inconsistent implementations of this variable across many different actors. This adds a unified implementation of this variable inside of IProtocol. Depends on D12955
Reporter | ||
Comment 2•4 years ago
|
||
This should eliminate most variables which can be replaced with IPCOpen(). Depends on D12956
Pushed by nika@thelayzells.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/123b5d5a3637 Part 1: Maintain an IPCOpen variable in IProtocol, r=mccr8 https://hg.mozilla.org/integration/mozilla-inbound/rev/6494840edc17 Part 2: Remove now-unnecessary mIPCOpen variable, r=mccr8
Comment 4•4 years ago
|
||
Backed out 13 changesets (bug 1500948, bug 1509362, bug 1509591, bug 1448426, bug 1500949, bug 1487249, bug 1509930, bug 1500950, bug 1500944) for causing crashes and assertion failures on PBackgroundParent.cpp:696 CLOSED TREE Backout revision https://hg.mozilla.org/integration/mozilla-inbound/rev/9bfe29337ffe3d93cd060077e2e999e72bb9b7cf Failed push https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=214255312&revision=c3fe435e473a463fbc22d4afa531bdedb757079c Failure logs: https://treeherder.mozilla.org/logviewer.html#?job_id=214255312&repo=mozilla-inbound https://treeherder.mozilla.org/logviewer.html#?job_id=214255794&repo=mozilla-inbound https://treeherder.mozilla.org/logviewer.html#?job_id=214249038&repo=mozilla-inbound https://treeherder.mozilla.org/logviewer.html#?job_id=214249630&repo=mozilla-inbound :Nika Layzell Could you please take a look?
Flags: needinfo?(nika)
Reporter | ||
Comment 5•4 years ago
|
||
Reporter | ||
Comment 6•4 years ago
|
||
Updated•4 years ago
|
Attachment #9028838 -
Attachment is obsolete: true
Reporter | ||
Comment 7•4 years ago
|
||
clearing ni? for when I get back to this in the future.
Flags: needinfo?(nika)
Updated•4 years ago
|
Attachment #9028751 -
Attachment is obsolete: true
Reporter | ||
Updated•4 years ago
|
Assignee: nika → nobody
Summary: Unify mIPCOpen implementations → Eliminate mIPCOpen in favor of IProtocol::CanSend()
Updated•4 months ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•