1509681 - Container checkbox not showing check mark (Multi Account Containers)

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[Alberto]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

Open site in Personal Container. Click on Multi-Account Containers icon. Check Always open in Personal Container. Nothing appears to happen.


Actual results:

Check box does not display check mark but does succeed in selecting the option. This can be verified by clicking on edit. The entry will be there.


Expected results:

Check box should toggle check mark.

Comment 1

[u554753]

Hi Alberto, 

Can you clarify your STR? I opened a website in a personal container but do not see a multi-account containers icon. Can you attach a screenshot or clarify your steps to access the multi-account containers? Thanks!

Comment 2

[Alberto]

Hi Grover,

You need to install the Firefox Multi-Account Containers add-on:

https://addons.mozilla.org/en-US/firefox/addon/multi-account-containers/

This will give you the taskbar icon.

Steps to reproduce:

1. Open a container.

2. Open site in that container.

3. Click on Multi-account Containers icon

4. Click ONCE ONLY checkbox "always open in Container (name of current container)."

5. Note: no checkmark appears in box.

6. Close tab.

7. Open site again.

8. You should be asked if you wish to always open site in this container. If not redo steps as you've probably clicked the checkbox twice.

Comment 3

[Alberto]

Attachment: Screenshot 2018-12-01 10.59.30.jpg

Comment 4

[Alice0775 White]

[Tracking Requested - why for this release]:broken checkbox in webext arrow panel

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f139e12a965aa11e643025558e8d05a47cfd419a&tochange=c130b91ccc54849b61a6c3ecb0176decb9dcec61

Regressed by:
	c130b91ccc54	Tim Nguyen — Bug 1491609 - Update common.inc.css checkbox and radio styling. r=jaws,k88hudson

@:ntim
Your patch causes the regression, can you please look into this?

Comment 5

[Tim Nguyen :ntim]

Jonathan, bug 1491609 removed the checkmark image that multi-account-containers is using (https://github.com/mozilla/multi-account-containers/blob/220b90214484ba52c17e9ba3b6d8137e8bc24f4a/src/css/popup.css#L541). Add-ons should really not rely on Firefox's internal images. Could you please look into this or find someone who can ? 

Thanks!

Comment 6

[Julien Cristau [:jcristau]]

Sounds like https://github.com/mozilla/multi-account-containers/issues/1306 / https://github.com/mozilla/multi-account-containers/pull/1295?  Looks like this will be fixed on the add-on side.  NI?groovecoder as the reviewer for that PR, can you maybe expedite that change before 64 goes to release next week?

Comment 7

[Alberto]

Thanks everyone!

Comment 8

[Luke Crouch [:groovecoder]]

The PR is merged & released on AMO. Check 64 again?

Comment 9

[Alberto]

Fixed. Thanks!

Comment 10

[Alberto]

Resolved. Please close.