Closed Bug 1509753 Opened 11 months ago Closed 11 months ago

Port bug 1437638 - Use XULFrameElement instead of XULElement in instanceof check

Categories

(Thunderbird :: Add-Ons: Extensions API, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 65.0

People

(Reporter: Fallen, Assigned: Fallen)

Details

Attachments

(1 file)

Without this patch, an onConnect listener will have port.sender.tab undefined. m-c changed XULElement to XULFrameElement, which we can easily port.

https://searchfox.org/mozilla-central/rev/f997bd6bbfc4773e774fdb6cd010142370d186f9/browser/components/extensions/parent/ext-browser.js#37
Attached patch Fix - v1Splinter Review
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #9027416 - Flags: review?(geoff)
Attachment #9027416 - Flags: review?(geoff) → review+
Keywords: checkin-needed
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/8199346174a7
Use XULFrameElement instead of XULElement when determining sender. r=darktrojan
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 65.0
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.