--with-system-nspr: drop GNU regex extension when using sed

RESOLVED FIXED in Firefox -esr60

Status

defect
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: jbeich, Assigned: jbeich)

Tracking

({regression})

Trunk
mozilla65
Unspecified
FreeBSD
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr6064+ fixed, firefox63 wontfix, firefox64 fixed, firefox65 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

6 months ago
FreeBSD sed uses BSD regex which is going to desupport escaping ordinary characters. Previously, \S was treated as S but due to * it was elided. Now that sed aborts the build fails because ac_configure_args ends up empty:

In file included from objdir/dom/workers/Unified_cpp_dom_workers0.cpp:11:
dom/workers/ChromeWorkerScope.cpp:56:10: error: use of undeclared identifier 'JS_InitCTypesClass'
    if (!JS_InitCTypesClass(aCx, aGlobal) ||
         ^
dom/workers/ChromeWorkerScope.cpp:61:18: error: unknown type name 'JSCTypesCallbacks'
    static const JSCTypesCallbacks callbacks = {
                 ^

http://package18.nyi.freebsd.org/data/headamd64PR229925-default/2018-08-03_22h32m51s/logs/errors/firefox-esr-60.1.0_4,1.log
Assignee

Comment 1

6 months ago
Posted patch v1Splinter Review
Note, extra [ ] are for autoconf escaping.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0cd14f4d754d8fdc98bdcdcdb8a41e1255edfd5
Assignee: nobody → jbeich
Attachment #9027428 - Flags: review?(core-build-config-reviews)
Attachment #9027428 - Flags: review?(core-build-config-reviews) → review+
Assignee

Updated

6 months ago
Keywords: checkin-needed

Comment 2

6 months ago
Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/79b57272e805
Don't rely on GNU regex extension for character classes. r=froydnj
Keywords: checkin-needed

Comment 3

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/79b57272e805
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Assignee

Comment 4

6 months ago
Comment on attachment 9027428 [details] [diff] [review]
v1

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 975011

User impact if declined: Broken build on FreeBSD 13.0. Can be worked around via sed -> gsed alias/symlink but this can break other software.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): --with-system-nspr is NPOTB. Otherwise, can only break build.

String changes made/needed: 

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: - Facilitate building projects based on ESR e.g., Tor Browser
- Allow building Firefox ESR without downstream patches e.g., for more vanilla experience

User impact if declined: Broken build on FreeBSD 13.0. Can be worked around via sed -> gsed alias/symlink but this can break other software.

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): --with-system-nspr is NPOTB. Otherwise, can only break build.

String or UUID changes made by this patch:
Attachment #9027428 - Flags: approval-mozilla-esr60?
Attachment #9027428 - Flags: approval-mozilla-beta?
Comment on attachment 9027428 [details] [diff] [review]
v1

Support for downstream builds, OK to uplift to beta and ESR.
Attachment #9027428 - Flags: approval-mozilla-esr60?
Attachment #9027428 - Flags: approval-mozilla-esr60+
Attachment #9027428 - Flags: approval-mozilla-beta?
Attachment #9027428 - Flags: approval-mozilla-beta+
Keywords: regression
Target Milestone: Firefox 65 → mozilla65
You need to log in before you can comment on or make changes to this bug.