Closed
Bug 1509757
Opened 5 years ago
Closed 5 years ago
--with-system-nspr: drop GNU regex extension when using sed
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox-esr6064+ fixed, firefox63 wontfix, firefox64 fixed, firefox65 fixed)
RESOLVED
FIXED
mozilla65
People
(Reporter: jbeich, Assigned: jbeich)
References
Details
(Keywords: regression)
Attachments
(1 file)
1.37 KB,
patch
|
froydnj
:
review+
lizzard
:
approval-mozilla-beta+
lizzard
:
approval-mozilla-esr60+
|
Details | Diff | Splinter Review |
FreeBSD sed uses BSD regex which is going to desupport escaping ordinary characters. Previously, \S was treated as S but due to * it was elided. Now that sed aborts the build fails because ac_configure_args ends up empty: In file included from objdir/dom/workers/Unified_cpp_dom_workers0.cpp:11: dom/workers/ChromeWorkerScope.cpp:56:10: error: use of undeclared identifier 'JS_InitCTypesClass' if (!JS_InitCTypesClass(aCx, aGlobal) || ^ dom/workers/ChromeWorkerScope.cpp:61:18: error: unknown type name 'JSCTypesCallbacks' static const JSCTypesCallbacks callbacks = { ^ http://package18.nyi.freebsd.org/data/headamd64PR229925-default/2018-08-03_22h32m51s/logs/errors/firefox-esr-60.1.0_4,1.log
Note, extra [ ] are for autoconf escaping. https://treeherder.mozilla.org/#/jobs?repo=try&revision=d0cd14f4d754d8fdc98bdcdcdb8a41e1255edfd5
Assignee: nobody → jbeich
Attachment #9027428 -
Flags: review?(core-build-config-reviews)
Updated•5 years ago
|
Attachment #9027428 -
Flags: review?(core-build-config-reviews) → review+
Keywords: checkin-needed
Pushed by ncsoregi@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/79b57272e805 Don't rely on GNU regex extension for character classes. r=froydnj
Keywords: checkin-needed
Comment 3•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/79b57272e805
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Comment on attachment 9027428 [details] [diff] [review] v1 [Beta/Release Uplift Approval Request] Feature/Bug causing the regression: Bug 975011 User impact if declined: Broken build on FreeBSD 13.0. Can be worked around via sed -> gsed alias/symlink but this can break other software. Is this code covered by automated tests?: Yes Has the fix been verified in Nightly?: Yes Needs manual test from QE?: No If yes, steps to reproduce: List of other uplifts needed: None Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): --with-system-nspr is NPOTB. Otherwise, can only break build. String changes made/needed: [ESR Uplift Approval Request] If this is not a sec:{high,crit} bug, please state case for ESR consideration: - Facilitate building projects based on ESR e.g., Tor Browser - Allow building Firefox ESR without downstream patches e.g., for more vanilla experience User impact if declined: Broken build on FreeBSD 13.0. Can be worked around via sed -> gsed alias/symlink but this can break other software. Fix Landed on Version: 65 Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): --with-system-nspr is NPOTB. Otherwise, can only break build. String or UUID changes made by this patch:
Attachment #9027428 -
Flags: approval-mozilla-esr60?
Attachment #9027428 -
Flags: approval-mozilla-beta?
Comment 5•5 years ago
|
||
Comment on attachment 9027428 [details] [diff] [review] v1 Support for downstream builds, OK to uplift to beta and ESR.
Attachment #9027428 -
Flags: approval-mozilla-esr60?
Attachment #9027428 -
Flags: approval-mozilla-esr60+
Attachment #9027428 -
Flags: approval-mozilla-beta?
Attachment #9027428 -
Flags: approval-mozilla-beta+
Updated•5 years ago
|
tracking-firefox-esr60:
--- → 64+
Comment 6•5 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/460fc055455e
Comment 7•5 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-esr60/rev/fbba8450659f
Updated•5 years ago
|
Updated•5 years ago
|
Keywords: regression
Target Milestone: Firefox 65 → mozilla65
Updated•5 years ago
|
Keywords: regression
You need to log in
before you can comment on or make changes to this bug.
Description
•