[wpt-sync] Sync PR 14228 - Add tests that subclassing {Transform,Writable}Stream works

RESOLVED FIXED in Firefox 66

Status

()

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement
Importance:
P4
normal
Status:
RESOLVED FIXED
Reported:
6 months ago
Modified:
2 months ago

People

(Reporter: wptsync, Unassigned)

Tracking

Version:
unspecified
Target:
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

(Whiteboard: [wptsync downstream],
URL
)

Assignee

Description

•
6 months ago 
Sync web-platform-tests PR 14228 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14228
Details from upstream follow.

Adam Rice <ricea@chromium.org> wrote:
>  Add tests that subclassing {Transform,Writable}Stream works
>  
>  Change-Id: Iba151bf31367c06c94311402a9fc550d7bb87a6d
>  Reviewed-on: https://chromium-review.googlesource.com/1350550
>  WPT-Export-Revision: 1b639eb5b7be7ae644dfaea03c494d2518741e69
Assignee

Comment 1

•
6 months ago 
PR 14228 applied with additional changes from upstream: a89730a0f3638d709ccc42064c8f8eb8935b04f7
 Assignee

Updated

•
6 months ago
Component: web-platform-tests → DOM
Product: Testing → Core
 Assignee

Comment 5

•
6 months ago 
Ran 8 tests and 164 subtests
OK     : 8
FAIL   : 164

New tests that have failures or other problems:
/streams/transform-streams/general.any.html
    Identity TransformStream: can read from readable what is put into writable: FAIL
    Subclassing TransformStream should work: FAIL
    Transform stream should call transformer methods as methods: FAIL
    TransformStream can be constructed with a transform function: FAIL
    TransformStream can be constructed with no transform function: FAIL
    TransformStream instances must have writable and readable properties of the correct types: FAIL
    TransformStream start, transform, and flush should be strictly ordered: FAIL
    TransformStream writable starts in the writable state: FAIL
    TransformStream: by default, closing the writable closes the readable (when there are no queued writes): FAIL
    TransformStream: by default, closing the writable closes the readable after async enqueues and async done: FAIL
    TransformStream: by default, closing the writable closes the readable after sync enqueues and async done: FAIL
    TransformStream: by default, closing the writable waits for transforms to finish before closing both: FAIL
    Uppercaser async TransformStream: can read from readable transformed version of what is put into writable: FAIL
    Uppercaser sync TransformStream: can read from readable transformed version of what is put into writable: FAIL
    Uppercaser-doubler async TransformStream: can read both chunks put into the readable: FAIL
    Uppercaser-doubler sync TransformStream: can read both chunks put into the readable: FAIL
    closing the writable should close the readable when there are no queued chunks, even with backpressure: FAIL
    controller.terminate() should do nothing the second time it is called: FAIL
    enqueue() should throw after controller.terminate(): FAIL
    enqueue() should throw after readable.cancel(): FAIL
    it should be possible to call transform() synchronously: FAIL
    methods should not not have .apply() or .call() called: FAIL
    specifying a defined readableType should throw: FAIL
    specifying a defined writableType should throw: FAIL
    start() should not be called twice: FAIL
    terminate() should do nothing after readable.cancel(): FAIL
/streams/transform-streams/general.any.serviceworker.html
    Identity TransformStream: can read from readable what is put into writable: FAIL
    Subclassing TransformStream should work: FAIL
    Transform stream should call transformer methods as methods: FAIL
    TransformStream can be constructed with a transform function: FAIL
    TransformStream can be constructed with no transform function: FAIL
    TransformStream instances must have writable and readable properties of the correct types: FAIL
    TransformStream start, transform, and flush should be strictly ordered: FAIL
    TransformStream writable starts in the writable state: FAIL
    TransformStream: by default, closing the writable closes the readable (when there are no queued writes): FAIL
    TransformStream: by default, closing the writable closes the readable after async enqueues and async done: FAIL
    TransformStream: by default, closing the writable closes the readable after sync enqueues and async done: FAIL
    TransformStream: by default, closing the writable waits for transforms to finish before closing both: FAIL
    Uppercaser async TransformStream: can read from readable transformed version of what is put into writable: FAIL
    Uppercaser sync TransformStream: can read from readable transformed version of what is put into writable: FAIL
    Uppercaser-doubler async TransformStream: can read both chunks put into the readable: FAIL
    Uppercaser-doubler sync TransformStream: can read both chunks put into the readable: FAIL
    closing the writable should close the readable when there are no queued chunks, even with backpressure: FAIL
    controller.terminate() should do nothing the second time it is called: FAIL
    enqueue() should throw after controller.terminate(): FAIL
    enqueue() should throw after readable.cancel(): FAIL
    it should be possible to call transform() synchronously: FAIL
    methods should not not have .apply() or .call() called: FAIL
    specifying a defined readableType should throw: FAIL
    specifying a defined writableType should throw: FAIL
    start() should not be called twice: FAIL
    terminate() should do nothing after readable.cancel(): FAIL
/streams/transform-streams/general.any.sharedworker.html
    Identity TransformStream: can read from readable what is put into writable: FAIL
    Subclassing TransformStream should work: FAIL
    Transform stream should call transformer methods as methods: FAIL
    TransformStream can be constructed with a transform function: FAIL
    TransformStream can be constructed with no transform function: FAIL
    TransformStream instances must have writable and readable properties of the correct types: FAIL
    TransformStream start, transform, and flush should be strictly ordered: FAIL
    TransformStream writable starts in the writable state: FAIL
    TransformStream: by default, closing the writable closes the readable (when there are no queued writes): FAIL
    TransformStream: by default, closing the writable closes the readable after async enqueues and async done: FAIL
    TransformStream: by default, closing the writable closes the readable after sync enqueues and async done: FAIL
    TransformStream: by default, closing the writable waits for transforms to finish before closing both: FAIL
    Uppercaser async TransformStream: can read from readable transformed version of what is put into writable: FAIL
    Uppercaser sync TransformStream: can read from readable transformed version of what is put into writable: FAIL
    Uppercaser-doubler async TransformStream: can read both chunks put into the readable: FAIL
    Uppercaser-doubler sync TransformStream: can read both chunks put into the readable: FAIL
    closing the writable should close the readable when there are no queued chunks, even with backpressure: FAIL
    controller.terminate() should do nothing the second time it is called: FAIL
    enqueue() should throw after controller.terminate(): FAIL
    enqueue() should throw after readable.cancel(): FAIL
    it should be possible to call transform() synchronously: FAIL
    methods should not not have .apply() or .call() called: FAIL
    specifying a defined readableType should throw: FAIL
    specifying a defined writableType should throw: FAIL
    start() should not be called twice: FAIL
    terminate() should do nothing after readable.cancel(): FAIL
/streams/transform-streams/general.any.worker.html
    Identity TransformStream: can read from readable what is put into writable: FAIL
    Subclassing TransformStream should work: FAIL
    Transform stream should call transformer methods as methods: FAIL
    TransformStream can be constructed with a transform function: FAIL
    TransformStream can be constructed with no transform function: FAIL
    TransformStream instances must have writable and readable properties of the correct types: FAIL
    TransformStream start, transform, and flush should be strictly ordered: FAIL
    TransformStream writable starts in the writable state: FAIL
    TransformStream: by default, closing the writable closes the readable (when there are no queued writes): FAIL
    TransformStream: by default, closing the writable closes the readable after async enqueues and async done: FAIL
    TransformStream: by default, closing the writable closes the readable after sync enqueues and async done: FAIL
    TransformStream: by default, closing the writable waits for transforms to finish before closing both: FAIL
    Uppercaser async TransformStream: can read from readable transformed version of what is put into writable: FAIL
    Uppercaser sync TransformStream: can read from readable transformed version of what is put into writable: FAIL
    Uppercaser-doubler async TransformStream: can read both chunks put into the readable: FAIL
    Uppercaser-doubler sync TransformStream: can read both chunks put into the readable: FAIL
    closing the writable should close the readable when there are no queued chunks, even with backpressure: FAIL
    controller.terminate() should do nothing the second time it is called: FAIL
    enqueue() should throw after controller.terminate(): FAIL
    enqueue() should throw after readable.cancel(): FAIL
    it should be possible to call transform() synchronously: FAIL
    methods should not not have .apply() or .call() called: FAIL
    specifying a defined readableType should throw: FAIL
    specifying a defined writableType should throw: FAIL
    start() should not be called twice: FAIL
    terminate() should do nothing after readable.cancel(): FAIL
/streams/writable-streams/general.any.html
    Subclassing WritableStream should work: FAIL
    WritableStream should call underlying sink methods as methods: FAIL
    WritableStream's strategy.size should not be called as a method: FAIL
    closed and ready on a released writer: FAIL
    desiredSize initial value: FAIL
    desiredSize on a released writer: FAIL
    desiredSize on a writer for a closed stream: FAIL
    desiredSize on a writer for an errored stream: FAIL
    methods should not not have .apply() or .call() called: FAIL
    ready promise should fire before closed on releaseLock: FAIL
    redundant releaseLock() is no-op: FAIL
    ws.getWriter() on a closed WritableStream: FAIL
    ws.getWriter() on a closing WritableStream: FAIL
    ws.getWriter() on an aborted WritableStream: FAIL
    ws.getWriter() on an errored WritableStream: FAIL
/streams/writable-streams/general.any.serviceworker.html
    Subclassing WritableStream should work: FAIL
    WritableStream should call underlying sink methods as methods: FAIL
    WritableStream's strategy.size should not be called as a method: FAIL
    closed and ready on a released writer: FAIL
    desiredSize initial value: FAIL
    desiredSize on a released writer: FAIL
    desiredSize on a writer for a closed stream: FAIL
    desiredSize on a writer for an errored stream: FAIL
    methods should not not have .apply() or .call() called: FAIL
    ready promise should fire before closed on releaseLock: FAIL
    redundant releaseLock() is no-op: FAIL
    ws.getWriter() on a closed WritableStream: FAIL
    ws.getWriter() on a closing WritableStream: FAIL
    ws.getWriter() on an aborted WritableStream: FAIL
    ws.getWriter() on an errored WritableStream: FAIL
/streams/writable-streams/general.any.sharedworker.html
    Subclassing WritableStream should work: FAIL
    WritableStream should call underlying sink methods as methods: FAIL
    WritableStream's strategy.size should not be called as a method: FAIL
    closed and ready on a released writer: FAIL
    desiredSize initial value: FAIL
    desiredSize on a released writer: FAIL
    desiredSize on a writer for a closed stream: FAIL
    desiredSize on a writer for an errored stream: FAIL
    methods should not not have .apply() or .call() called: FAIL
    ready promise should fire before closed on releaseLock: FAIL
    redundant releaseLock() is no-op: FAIL
    ws.getWriter() on a closed WritableStream: FAIL
    ws.getWriter() on a closing WritableStream: FAIL
    ws.getWriter() on an aborted WritableStream: FAIL
    ws.getWriter() on an errored WritableStream: FAIL
/streams/writable-streams/general.any.worker.html
    Subclassing WritableStream should work: FAIL
    WritableStream should call underlying sink methods as methods: FAIL
    WritableStream's strategy.size should not be called as a method: FAIL
    closed and ready on a released writer: FAIL
    desiredSize initial value: FAIL
    desiredSize on a released writer: FAIL
    desiredSize on a writer for a closed stream: FAIL
    desiredSize on a writer for an errored stream: FAIL
    methods should not not have .apply() or .call() called: FAIL
    ready promise should fire before closed on releaseLock: FAIL
    redundant releaseLock() is no-op: FAIL
    ws.getWriter() on a closed WritableStream: FAIL
    ws.getWriter() on a closing WritableStream: FAIL
    ws.getWriter() on an aborted WritableStream: FAIL
    ws.getWriter() on an errored WritableStream: FAIL

Comment 6

•
5 months ago 
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1261a407197b
[wpt PR 14228] - Add tests that subclassing {Transform,Writable}Stream works, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f1dd7944d50
[wpt PR 14228] - Update wpt metadata, a=testonly

Comment 7

•
5 months ago 
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/06b31322e40b
[wpt PR 14228] - Add tests that subclassing {Transform,Writable}Stream works, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8c8e7d9c2b4
[wpt PR 14228] - Update wpt metadata, a=testonly

Comment 8

•
5 months ago
bugherder 
https://hg.mozilla.org/mozilla-central/rev/06b31322e40b
https://hg.mozilla.org/mozilla-central/rev/d8c8e7d9c2b4
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox66: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.