[wpt-sync] Sync PR 14230 - Fix CSSPreloadScanner to avoid missing rules (reland)

RESOLVED FIXED in Firefox 66

Status

enhancement
P4
normal
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: wptsync, Unassigned)

Tracking

unspecified
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

(Whiteboard: [wptsync downstream], )

Sync web-platform-tests PR 14230 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14230
Details from upstream follow.

Yoav Weiss <yoavweiss@chromium.org> wrote:
>  Fix CSSPreloadScanner to avoid missing rules (reland)
>  
>  This fixes a couple of bugs with the CSSPReloadScanner that made it miss
>  rules in which the URL wasn't quoted or the rule didn't end with a
>  semicolon. It also adds tentative WPT tests for that functionality, as
>  the tests are also relevant for WebKit.
>  
>  This is a reland of
>  https://chromium-review.googlesource.com/c/chromium/src/+/1331042
>  
>  Bug: 903785
>  Change-Id: I401c252a42fbb96dee9c7942e0a4f8d5b6850244
>  TBR: kouhei
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1349980
>  WPT-Export-Revision: fb7603b7bc24080434f4c7c5f969d60e3bf2f07a
Ran 5 tests and 5 subtests
OK     : 5
FAIL   : 5

New tests that have failures or other problems:
/loading/preloader-css-import-no-quote.tentative.html
    Imported inline CSS with no quote is not blocked on pending CSS: FAIL
/loading/preloader-css-import-no-semicolon.tentative.html
    Imported inline CSS with no semicolon is not blocked on pending CSS: FAIL
/loading/preloader-css-import-no-space.tentative.html
    Imported inline CSS with no quote is not blocked on pending CSS: FAIL
/loading/preloader-css-import-single-quote.tentative.html
    Imported inline CSS is not blocked on pending CSS: FAIL
/loading/preloader-css-import.tentative.html
    Imported inline CSS is not blocked on pending CSS: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/15eb57180700
[wpt PR 14230] - Fix CSSPreloadScanner to avoid missing rules (reland), a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/41e2805d6b57
[wpt PR 14230] - Update wpt metadata, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca898299e7e7
[wpt PR 14230] - Fix CSSPreloadScanner to avoid missing rules (reland), a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d252ff54d6d
[wpt PR 14230] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/ca898299e7e7
https://hg.mozilla.org/mozilla-central/rev/5d252ff54d6d
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.