[wpt-sync] Sync PR 14234 - Align resource timing buffer full processing to spec PR 168 (reland)

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P4
normal
RESOLVED FIXED
7 months ago
3 months ago

People

(Reporter: wptsync, Unassigned)

Tracking

unspecified
mozilla66
Points:
---

Firefox Tracking Flags

(firefox66 fixed)

Details

(Whiteboard: [wptsync downstream], )

Assignee

Description

7 months ago
Sync web-platform-tests PR 14234 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/14234
Details from upstream follow.

Yoav Weiss <yoavweiss@chromium.org> wrote:
>  Align resource timing buffer full processing to spec PR 168 (reland)
>  
>  This change implements the processing model from PR 168[1], when
>  it comes to setResourceTimingBufferSize(), clearResourceTimings()
>  and the firing of the resourcetimingbufferfull event.
>  
>  This is a reland of
>  https://chromium-review.googlesource.com/c/chromium/src/+/1345269
>  (but with nicer tests).
>  
>  [1] https://github.com/w3c/resource-timing/pull/168
>  
>  Change-Id: I10431bfda7f79b484c7ee5c608bb8a360d905339
>  Bug: 908181, 908414
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1350950
>  WPT-Export-Revision: e86b8d8a9a87365b04e2a56d310c13df50fda617
Assignee

Updated

7 months ago
Component: web-platform-tests → DOM
Product: Testing → Core
Assignee

Comment 9

7 months ago
Ran 12 tests and 15 subtests
OK     : 3
PASS   : 3
FAIL   : 3
TIMEOUT: 13
ERROR  : 4
NOTRUN : 1

Existing tests that now have a worse result (e.g. they used to PASS and now FAIL):
/service-workers/service-worker/performance-timeline.https.html: TIMEOUT
    Resource Timing: TIMEOUT
    Test Performance Timeline API in Service Worker: TIMEOUT
    empty service worker fetch event included in performance timings: NOTRUN

New tests that have failures or other problems:
/resource-timing/buffer-full-add-after-full-event.html: TIMEOUT
    Test that entry was added to the buffer after a buffer full event: TIMEOUT
/resource-timing/buffer-full-add-entries-during-callback-that-drop.html: TIMEOUT
    Test that entries synchronously added to the buffer during the callback are dropped: TIMEOUT
/resource-timing/buffer-full-add-entries-during-callback.html: TIMEOUT
    Test that entries synchronously added to the buffer during the callback don't get dropped if the buffer is increased: TIMEOUT
/resource-timing/buffer-full-add-then-clear.html: ERROR
    Test that if the buffer is cleared after entries were added to the secondary buffer, those entries make it into the primary one: FAIL
/resource-timing/buffer-full-inspect-buffer-during-callback.html: ERROR
    Test that entries in the secondary buffer are not exposed during the callback and before they are copied to the primary buffer: TIMEOUT
/resource-timing/buffer-full-set-to-current-buffer.html: TIMEOUT
    Test that entries added and event firing happened in the right sequence: TIMEOUT
/resource-timing/buffer-full-store-and-clear-during-callback.html
    Test that entries overflowing the buffer trigger the buffer full event, can be stored, and find themselves in the primary buffer after it's cleared.: FAIL
/resource-timing/buffer-full-then-increased.html: ERROR
    Test that overflowing the buffer and immediately increasing its limit does not trigger the resourcetimingbufferfull event: FAIL
/resource-timing/buffer-full-when-populate-entries.html: ERROR
    Test that a buffer full event does not bubble and that resourcetimingbufferfull is called only once per overflow: TIMEOUT

Comment 10

7 months ago
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/af450646a969
[wpt PR 14234] - Align resource timing buffer full processing to spec PR 168 (reland), a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/e6d78f16bd73
[wpt PR 14234] - Update wpt metadata, a=testonly

Comment 11

7 months ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/359a084be753
[wpt PR 14234] - Align resource timing buffer full processing to spec PR 168 (reland), a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/3d6017522769
[wpt PR 14234] - Update wpt metadata, a=testonly

Comment 12

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/359a084be753
https://hg.mozilla.org/mozilla-central/rev/3d6017522769
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.