1509872 - 1017798-1.html is busted after changes in bug 1416999

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Kartikaya Gupta (email:[e-mail])]

I happened to see this in a crashtest log while looking at unrelated things:

[task 2018-11-24T21:30:38.952Z] 21:30:38     INFO - REFTEST TEST-LOAD | file:///builds/worker/workspace/build/tests/reftest/tests/layout/style/crashtests/1017798-1.html | 2881 / 3638 (79%)
[task 2018-11-24T21:30:39.060Z] 21:30:39     INFO - ++DOMWINDOW == 73 (0x7f8aea660c00) [pid = 1126] [serial = 8443] [outer = 0x7f8aed560c00]
[task 2018-11-24T21:30:39.080Z] 21:30:39     INFO - JavaScript error: file:///builds/worker/workspace/build/tests/reftest/tests/layout/style/crashtests/1017798-1.html, line 112: ReferenceError: proto is not defined
[task 2018-11-24T21:30:39.105Z] 21:30:39     INFO - [Child 1126, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file /builds/worker/workspace/build/src/dom/base/nsContentUtils.cpp, line 4035
[task 2018-11-24T21:30:39.136Z] 21:30:39     INFO - REFTEST TEST-PASS | file:///builds/worker/workspace/build/tests/reftest/tests/layout/style/crashtests/1017798-1.html | (LOAD ONLY)
[task 2018-11-24T21:30:39.137Z] 21:30:39     INFO - REFTEST TEST-END | file:///builds/worker/workspace/build/tests/reftest/tests/layout/style/crashtests/1017798-1.html

Looks like the JS error makes the test bogus. The error was introduced by the change in bug 1416999.

Comment 1

[Edgar Chen [:edgar]]

Thanks for catching this.

Comment 2

[Edgar Chen [:edgar]]

Attachment: Bug 1509872 - Fix the JavaScript error in 1017798-1.html that is introduced by bug 1416999;

Comment 3

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1&revision=267eb769874e648fd943cd6ae5cb468148066db7&group_state=expanded

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c4f0bf2be1c
Fix the JavaScript error in 1017798-1.html that is introduced by bug 1416999; r=smaug

Comment 5

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/2c4f0bf2be1c