Closed Bug 1509955 Opened Last year Closed Last year

Preemptively fix unified bustage in layout/base

Categories

(Core :: Layout, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

Details

Attachments

(2 files)

Attached file build error output
(formerly bug 1468590, bug 1480213)


layout/base doesn't quite build successfully right now, when I disable unified builds (by doing s/UNIFIED_SOURCES/SOURCES/ in its moz.build file)

Build errors attached. Patch coming up to address them.
Just adding:
 - a missing-but-needed forward-decl (in LayersLogging.h which is
   included by files in layout/base).
 - a 'using' decl (to provide layers::AnimationInfo).
 - a missing-but-needed #include for nsCOMPtr.
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/38acc9df8e69
Preemptively fix unified bustage in layout/base. r=TYLin
https://hg.mozilla.org/mozilla-central/rev/38acc9df8e69
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.