Port Bug 1503824 Migrate the treecols binding into a custom element

RESOLVED FIXED in Thunderbird 65.0

Status

enhancement
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: jorgk, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 65.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

6 months ago
As per bug 1503824 comment #10 (quoted here):

Just a heads up that we are planning to remove the .tree-scrollable-columns wrapping hbox [0] so we can do the CE conversion on treecols without using Shadow DOM (and having to redo styles for treecolpicker).

As far as we can tell, this feature isn't used in Firefox, but I do see one place in TB [1] where there are styles set on that element - presumably you are expecting horizontally scrollable columns in that case? If so, you could probably just move that wrapping hbox into the tree's light DOM around the <treecol> elements when it's used in the document. You'll also need to restore the CSS rule in xul.css for that element.

[0]: https://searchfox.org/mozilla-central/rev/d35199ef15ffa57d190886e20d5df6471faf0870/toolkit/content/widgets/tree.xml#889
[1]: https://searchfox.org/comm-central/search?q=tree-scrollable&path=
Flags: needinfo?(richard.marti)
Flags: needinfo?(mkmelin+mozilla)
Flags: needinfo?(arshdkhn1)
Assignee

Comment 1

6 months ago
I asked Philipp in IRC if this tree-scrollable is still used. I think it's no more used.
Flags: needinfo?(richard.marti)
I think this is all that's needed.

Long calendar names do not need scrolling in the horizontal direction. The name just gets cropped.
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Flags: needinfo?(mkmelin+mozilla)
Attachment #9027679 - Flags: review?(makemyday)
Flags: needinfo?(arshdkhn1)
Or well, with this there's a slight change in that the row-highlighting doesn't start at the left window edge.
Assignee

Comment 4

6 months ago
Maybe 

calendar-list-tree treechildren::-moz-tree-row {
  padding-inline-start: 18px;
}

does it.
Unfortunately not, you don't get the indention then.
Assignee

Comment 6

6 months ago
This works for me.
Attachment #9027819 - Flags: review?(makemyday)
Assignee

Updated

6 months ago
Attachment #9027819 - Flags: feedback?(mkmelin+mozilla)
Comment on attachment 9027819 [details] [diff] [review]
1509982-tree-scrollable-columns.patch

Review of attachment 9027819 [details] [diff] [review]:
-----------------------------------------------------------------

This still doesn't indent the tree children
Attachment #9027819 - Flags: feedback?(mkmelin+mozilla)
Or did you try with some other patch applied?
Assignee

Comment 9

6 months ago
On Win10 it does with the m-c patches for the treecols and treecolpicker.
Assignee

Comment 10

6 months ago
On Ubuntu it works too with the m-c patches applied.
Ok, I didn't try with the m-c patches applied
Assignee

Comment 12

6 months ago
Yes, without the m-c patches it doesn't indent.
Assignee: mkmelin+mozilla → richard.marti
Attachment #9027679 - Attachment is obsolete: true
Attachment #9027679 - Flags: review?(makemyday)
Reporter

Comment 13

6 months ago
Comment on attachment 9027819 [details] [diff] [review]
1509982-tree-scrollable-columns.patch

For how long do you want to be busted while waiting for review?
Attachment #9027819 - Flags: review?(mkmelin+mozilla)
Comment on attachment 9027819 [details] [diff] [review]
1509982-tree-scrollable-columns.patch

Review of attachment 9027819 [details] [diff] [review]:
-----------------------------------------------------------------

I wouldn't say bustage, it would be a smaller visual glitch.
Attachment #9027819 - Flags: review?(mkmelin+mozilla)

Comment 15

6 months ago
Comment on attachment 9027819 [details] [diff] [review]
1509982-tree-scrollable-columns.patch

Review of attachment 9027819 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, looks good.
Attachment #9027819 - Flags: review?(makemyday) → review+
Assignee

Updated

6 months ago
Keywords: checkin-needed

Comment 16

6 months ago
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/3fb7643137ce
Port Bug 1503824: adjust CSS as .tree-scrollable-columns went away. r=MakeMyDay DONTBUILD
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Reporter

Updated

6 months ago
Target Milestone: --- → Thunderbird 65.0
You need to log in before you can comment on or make changes to this bug.