Open Bug 1510068 Opened 7 years ago Updated 7 years ago

Attempting to push to a closed revision leaves git at a detached HEAD

Categories

(Conduit :: moz-phab, defect, P3)

Product:
Conduit
Component:
moz-phab
Type:
defect

Tracking

(Not tracked)

People

(Reporter: kats, Unassigned)

Details

(Keywords: conduit-triaged)

I had a landed some patches that got backed out. I fixed the problem locally and pushed again (using `moz-phab submit --upstream master` on a git-cinnabar checkout). It did some work and then errored out with "This revision has already been closed". But then it also left my git checkout at a detached HEAD instead of properly restoring the branch that was checked out before.
this might be a duplicate of bug 1484838, however restoring the original branch in this case sounds like the right thing to do. zalun - any thoughts here?
Flags: needinfo?(pzalewa)
Calling finalize before exit if there is an error in arc might be a good idea. I'll experiment on that.
Flags: needinfo?(pzalewa)
Keywords: conduit-triaged
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.