Closed Bug 1510113 Opened 5 years ago Closed 5 years ago

Valgrind leaks in PR_SetEnv and SetWordEnv when nasm is enabled

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: TD-Linux, Assigned: TD-Linux)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1510113 - Never inline SaveToEnv or SaveWordToEnv.
47 bytes, text/x-phabricator-request
Details | Review 
This seems to be caused by LTO decisions changing, which causes different functions to be inlined and the valgrind exceptions to fail.

See: https://treeherder.mozilla.org/logviewer.html#?job_id=213272481&repo=try&lineNumber=45271
This allows Valgrind to recognize the call stacks to this function,
avoiding Valgrind warnings in intentional leaks in these functions.
Assignee: nobody → tdaede
Pushed by tdaede@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d085db32a53d
Never inline SaveToEnv or SaveWordToEnv. r=karlt
https://hg.mozilla.org/mozilla-central/rev/d085db32a53d
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox65: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.