1510276 - Inconsistent drive letter case leading to invalid/duplicated registry entries

Status: RESOLVED FIXED

(Firefox :: Installer, enhancement, P3)

Description

[Robert Strong (they/them - no direct email)]

Under HKLM Software\Clients\StartMenuInternet\Firefox-A3710B8EBB50CD3 I noticed a registry entry with a shell\open\command path that starts with a lowercase c.
"c:\Program Files\Nightly\firefox.exe"

When I already have HKLM Software\Clients\StartMenuInternet\Firefox-4FD8BA6A4A33F689 a shell\open\command that starts with an uppercase C
"C:\Program Files\Nightly\firefox.exe"

Interestingly, I only have FirefoxHTML-A3710B8EBB50CD3 and FirefoxURL-A3710B8EBB50CD3 under HKLM Software\classes and they both start with the uppercase C.

I've also noticed a couple of HKLM Software\classes\FirefoxHTML-<hash> and HKLM Software\classes\FirefoxURL-<hash> keys that only have shell\open\ddeexec and their values but don't have shell\open\command or DefaultIcon.

Comment 1

[Robert Strong (they/them - no direct email)]

Bah, just noticed that HKLM Software\Clients\StartMenuInternet\Firefox-A3710B8EBB50CD3 has the uppercase C and HKLM Software\Clients\StartMenuInternet\Firefox-4FD8BA6A4A33F689 has the lowercase c which makes much more sense.

Comment 2

[Molly Howell (she/her) (mostly inactive)]

Yeah, this sounds like $INSTDIR is getting initialized with inconsistent drive letter casing. I'm not sure how that's happening, presumably NSIS is setting $EXEDIR that way, but in any case that difference then causes ${InitHashAppModelId} to generate different hashes. I guess ${GetLongPath} needs to be normalizing the case of the drive letter. And once that's happening we should also probably take steps to make sure we don't create duplicate entries for installs that had previously always used the other case.

Comment 3

[Robert Strong (they/them - no direct email)]

Attachment: Bug 1510276 - Fix GetLongPath so it returns the proper case for the path. r?mhowell

Always uppercase the first char of the path in GetLongPath
Remove GetLongPathNameW since it isn't setting the proper case for the path segments below the leaf name

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9bb4a23d407
Fix GetLongPath so it returns the proper case for the path. r=mhowell

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/a9bb4a23d407