Status

enhancement
P1
normal
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: davehunt, Assigned: Bebe)

Tracking

(Blocks 1 bug)

Version 3
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

This tracks adding Wikipedia to tp6. Please use https://en.wikipedia.org/wiki/Barack_Obama for the test.
:vchin would you be happy with using the photo as the hero element for this page?
Flags: needinfo?(vchin)
That is fine. Is it easier or harder to use the Barack Obama title of the article or the image? Either is good in case one is easier than the other.
Flags: needinfo?(vchin)
Note: We tried adding Wikipedia (the same page as in the Description) in the most recent tp6 expansion (Bug 1503990) but the mitmproxy playback looked terrible - nothing like the actual page, so we had decided to pull out Wikipedia at that time so we could land the others.

Maybe :Bebe will have better luck with the recording this time. If not, we may need dev to have a look at it and see why mitmproxy doesn't handle Wikipedia well.
Assignee

Comment 4

6 months ago
I investigated this issue today.

Wiki is not working because we don't respond with the correct response when doing playback in mitmproxy.
See: https://searchfox.org/mozilla-central/source/testing/raptor/raptor/playback/alternate-server-replay.py#154

We generate the best match for the current request and return the last request in the list (candidate_flow)

Because of this we don't send the correct response and the site is not loading properly.


If we correct this and use "flow" wiki will start working but we break the "auto login" feature
Why are we not finding an exact match? I recall you saying that mitmproxy 4 doesn't have this issue, but it looks like the relevant code in mitmproxy hasn't been touched for 2 years. Could you explain what you mean by using "flow" and breaking "auto login"?
Flags: needinfo?(fstrugariu)
Assignee

Comment 7

6 months ago
Added wiki tests.

this is blocked by: 1511029

recording link:
 https://drive.google.com/drive/folders/1Dj5C2JwOWcmT8FBM01uvKXlKHWfKmXkQ?usp=sharing
Depends on: 1511029
Flags: needinfo?(fstrugariu)
Priority: -- → P1
Assignee

Comment 8

5 months ago
Updated 
Tested on firefox and chrome
Thanks :bebe, r+ latest update.

Please update the Raptor wiki and the https://github.com/mozilla/perf-automation repo before landing, thanks.
Flags: needinfo?(fstrugariu)

Comment 12

5 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
You need to log in before you can comment on or make changes to this bug.