[meta] Enable LSNG pref on Nightly

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P3
normal
RESOLVED FIXED
6 months ago
4 months ago

People

(Reporter: janv, Assigned: janv)

Tracking

({meta})

Trunk
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 wontfix, firefox66 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

6 months ago
Bug 1286798 is going to add a pref to control if we use our new LS implementation:

dom.storage.next_gen

The new implementation will be disabled by default on all branches for now, but once we get positive testing results from QA, we can flip the pref on Nightly.
We target 66 currently.
Assignee

Updated

6 months ago
Depends on: 1286798
Priority: -- → P3
Assignee

Updated

6 months ago
Depends on: 1505798, 1511418
Assignee

Updated

6 months ago
No longer depends on: 1511418
Assignee

Updated

5 months ago
Depends on: 1513850
Assignee

Updated

5 months ago
Depends on: 1513859
Assignee

Updated

5 months ago
See Also: → 1513881
Assignee

Updated

5 months ago
See Also: → 1286798
Assignee

Updated

5 months ago
Depends on: 1513892
Assignee

Updated

5 months ago
Keywords: meta
Summary: Enable LSNG pref on Nightly → [meta] Enable LSNG pref on Nightly
Assignee

Comment 2

5 months ago
There are patches for all bugs that block enabling LSNG on Nightly.
However I'm still working on a test for bug 1513892, but other than that, things look good.
Assignee

Comment 3

5 months ago
Posted patch patchSplinter Review
Once bug 1513892 is fixed, we can flip the pref.
Assignee: nobody → jvarga
Status: NEW → ASSIGNED
Attachment #9032807 - Flags: review?(bugmail)
Comment on attachment 9032807 [details] [diff] [review]
patch

Review of attachment 9032807 [details] [diff] [review]:
-----------------------------------------------------------------

Wooooooo!
Attachment #9032807 - Flags: review?(bugmail) → review+

Comment 7

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0f7da6819c47
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
This seems to be causing browser-wide freezing for me after a few minutes, especially when accessing Google; see bug 1516136. Maybe bug 1513859 did not resolve all sources of hanging?
I'm encountering crashes during triage that might be related to this change, first of all bug 1516231 which is a pretty tall spike. Then other stuff like this report:

https://crash-stats.mozilla.com/report/index/14107b32-76a8-409f-9ca6-834980181223

Updated

5 months ago
Depends on: 1516333
Depends on: 1516231
No longer depends on: 1516333
No longer depends on: 1516231
You need to log in before you can comment on or make changes to this bug.