Closed Bug 1510410 Opened 3 years ago Closed 3 years ago
[meta] Enable LSNG pref on Nightly
Bug 1286798 is going to add a pref to control if we use our new LS implementation: dom.storage.next_gen The new implementation will be disabled by default on all branches for now, but once we get positive testing results from QA, we can flip the pref on Nightly. We target 66 currently.
Here are latest performance testing results: Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c82306f77dbbebfb0fc6530a008ce95076924594 Talos comparison (all talos tests): https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&newProject=try&newRevision=c82306f77dbbebfb0fc6530a008ce95076924594&framework=1&selectedTimeRange=172800 Raptor comparison (only tp6-1, tp6-2, tp6-3, tp6-4, tp6-5, tp6-6): https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&newProject=try&newRevision=c82306f77dbbebfb0fc6530a008ce95076924594&framework=10&selectedTimeRange=172800 It seems there are no performance regressions with LSNG enabled.
Summary: Enable LSNG pref on Nightly → [meta] Enable LSNG pref on Nightly
There are patches for all bugs that block enabling LSNG on Nightly. However I'm still working on a test for bug 1513892, but other than that, things look good.
Once bug 1513892 is fixed, we can flip the pref.
Assignee: nobody → jvarga
Status: NEW → ASSIGNED
Attachment #9032807 - Flags: review?(bugmail)
Comment on attachment 9032807 [details] [diff] [review] patch Review of attachment 9032807 [details] [diff] [review]: ----------------------------------------------------------------- Wooooooo!
Attachment #9032807 - Flags: review?(bugmail) → review+
This seems to be causing browser-wide freezing for me after a few minutes, especially when accessing Google; see bug 1516136. Maybe bug 1513859 did not resolve all sources of hanging?
I'm encountering crashes during triage that might be related to this change, first of all bug 1516231 which is a pretty tall spike. Then other stuff like this report: https://crash-stats.mozilla.com/report/index/14107b32-76a8-409f-9ca6-834980181223
These new Fennec crashes also seem storage-related: https://crash-stats.mozilla.com/report/index/c59a0dfd-6ba4-4c63-bdb6-860c20181223 https://crash-stats.mozilla.com/report/index/7794b92c-f209-404a-8965-3dcbd0181223
You need to log in before you can comment on or make changes to this bug.