1510422 - Autocomplete stops working after typing await statement

Status: RESOLVED FIXED

(DevTools :: Console, defect, P1)

Description

[:Harald Kirschner :digitarald]

Attachment: await-autocomplete-space.gif

STR:
- Type `await navig` in Console

ER: Autocomplete dialog for `navigator`
AR: No autocomplete showing up

Pressing space and backspace after the STR triggers the autocomplete; so something within the state handling is off after await.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Probably caused by Bug 1462394 (was working in 64)

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1510422 - Fix autocomplete cache handling; r=Honza.

In Bug 1462394, we moved the autocomplete data handling
out of the JsTerm to the Redux store. In the process, we
regress some cases like `await n`, which should display
`navigator`, but isn't anymore when the user types the
whole sequence. Ctrl+Space would still show the popup,
which indicates that the issue is not on the server-side.

This issue is caused because our new code decides that
we should hit the cache when typing the `n`, and there's
nothing in the cache.

Previously, we were clearing the cache as soon as the input
last string wasn't alphanumeric, which we don't anymore.
To fix that, instead of relying on the last string of the
input (which could be wrong in cases like `x.["hello `), we
clear the cache when the autocomplete service returns a null
`matches` property.

In the JsPropertyProvider, we use to return null whenever
there isn't any search done (incorrect input, empty match prop, …).
So it seems like a good idea to bust the cache when the
server returns null.

This requires some changes to the autocomplete service, as well
as some in jsPropertyProvider (e.g. to handle `await `).

Tests are added both on the client and the frontend to make sure
we don't regress this (those tests fail without the actual fix).

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Here's a TRY push with the patch: https://treeherder.mozilla.org/#/jobs?repo=try&revision=774922e363f2dde7892a76853575fe0467f459fc (I only modified the commit summary before pushing to phabricator)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85dab0b93689
Fix autocomplete cache handling; r=Honza.

Comment 5

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/85dab0b93689