1510434 - [RTL] URL loses the domain highlight after switching from a New Tab to any other tab

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect)

Description

[Itiel]

Attachment: Screencast

This is a regression from bug 1503161.

STR:
1. Change Nightly's UI to RTL (set intl.uidirection to 1 in about:config) and restart Nightly
2. Open 2 New Tabs
3. In the second tab open any URL and let it finish loading
4. Go to the first tab (which should still be the New Tab)
5. Go back to the second tab.

AR:
The second tab's domain part of the URL is not hightlighted, and the entire URL is in the same color.

ER:
Hightlight the domain.

See attached.

Not sure if this is considered a security issue.

Comment 1

[:Gijs (he/him)]

Off-hand, I don't understand how a rule specific to the placeholder-shown case could cause an issue like this, as it shouldn't apply to the case where the tab has content loaded, with a URL. Perhaps the logic in https://searchfox.org/mozilla-central/source/browser/components/urlbar/UrlbarValueFormatter.jsm#69 isn't being run at the right time, or something? Dão, can you take a look?

Comment 2

[Dão Gottwald [:dao]]

I've backed out bug 1503161.