1510463 - Remove requirement to interrupt() thread when adding breakpoints

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Logan Smyth [:loganfsmyth]]

The source actor currently enforces the requirement that the debugger should be paused before you are allowed to add a breakpoint.

This requirement does not seem to be required by any specific piece of the API design, and most importantly, is frustrating because it makes it difficult to avoid race conditions. Requests to the API take time, and when adding a breakpoint, a client can't know whether the server needs to be paused first withing sending a packet to check. It's possible for the state to change between the time that the state was checked, and when the breakpoint-add packet was sent to the server. We currently have race conditions around this if you attempt to add multiple breakpoints at once, because each request will dispatch an `interrupt` before the first response comes back to indicate that the server has paused, making it unclear who is responsible for later resuming the thread.

Comment 1

[Jason Laster [:jlast]]

Attachment: Bug 1510463 - Allow adding breakpoints without pausing. r=jlast

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cef21809ef0
Allow adding breakpoints without pausing. r=jlast

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/3cef21809ef0

Comment 4

[Jim Blandy :jimb]

🎉