Closed
Bug 151047
Opened 22 years ago
Closed 22 years ago
Implement single click download and helper app launch
Categories
(Camino Graveyard :: Downloading, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Camino0.7
People
(Reporter: Saarinen, Assigned: sdagley)
References
Details
Attachments
(1 file, 1 obsolete file)
17.18 KB,
patch
|
Details | Diff | Splinter Review |
I am using Mac OS X (10.1.5) and Navigator 0.3.0 (11 June). Downloaded files do not activate the applicable helper application - most notably Stuffit Expander.
Assignee | ||
Comment 2•22 years ago
|
||
This isn't external protocol related. It depends on the nsLocalFileMac rewrite for the helper app dispatching.
Comment 3•22 years ago
|
||
another case of this: clicking a PDF file does nothing. it should launch Preview (or Adobe Acrobat, if that's being used instead). here's a sample link: http://hopey.mcom.com/tests/helper-apps/crcflame.pdf
Severity: minor → critical
QA Contact: winnie → sairuh
Assignee | ||
Comment 5•22 years ago
|
||
My assertion that the nsLocalFileOSX landing would fix this wasn't entirely correct, we still have problems under OS X in uriloader which I'm working on.
Comment 7•22 years ago
|
||
Build ID: 2002072308 - Selecting advance in the application request window enables auto-select of help applications for subsequent downloads of the associated type; however, the application requesting continues for each subsequent download even though the "Ask me before down loading this type" check box is not checked.
Assignee | ||
Comment 8•22 years ago
|
||
Updated bug summary to describe re-purposing of this bug. As we have discussed in the Chimera meetings a single click on a link that invokes a download will automatically download the file to the user's specified download folder and invoke the appropriate helper app. If the user desires UI to prompt for a different location for the link to be downloaded they'll use the contextual menu download option
Component: General → Bookmarks
Summary: Downloaded files do not activate helper application → Implement single click download and helper app launch
Assignee | ||
Comment 9•22 years ago
|
||
*** Bug 163687 has been marked as a duplicate of this bug. ***
Comment 10•22 years ago
|
||
Would this also apply to option-click downloads?
Assignee | ||
Comment 11•22 years ago
|
||
option-clicking on a link will still bring up the Save As... dialog for the link target
Comment 12•22 years ago
|
||
Then there is still no single-step way to download and save image, movie and text files, as well as .dmg & .gz files on misconfigured servers, which is the functionality I was missing from OmniWeb. Perhaps option-shift-click could bypass the dialog and route to the downloads folder?
Assignee | ||
Comment 13•22 years ago
|
||
Is option-click and pick a folder _that_ difficult? The problem is in the misconfigured servers, not Chimera. Which BTW, I'm running into a lot less these days - YMMV. Since one of Chimera's goals is to simplify the browsing experience we do _not_ want to pollute it with all sorts of different ways to download a file.
Assignee | ||
Comment 14•22 years ago
|
||
With this patch links that would normally be downloaded, e.g. .bin or .gz, will be downloaded automatically to the user's specified download folder and the appropriate helper app invoked
Comment 15•22 years ago
|
||
I would advocate making option-click download to the default downloads folder, without the save as dialog. That way you could set your destination once for all files, and save a step every time you download. This is how I have all my other browsers set up.
Updated•22 years ago
|
Component: Bookmarks → Downloading
QA Contact: sairuh → petersen
Assignee | ||
Comment 16•22 years ago
|
||
RalphNumbers: File a seperate RFE bug, your request has nothing to do with this bug (and it's a different code path but that's beside the point :-)
Assignee | ||
Comment 17•22 years ago
|
||
Removing dependencies: 118203 has been landed in the Chimera branch and the patch from 162700 is incorporated in the patch for this bug.
Assignee | ||
Comment 18•22 years ago
|
||
Same patch as before but updated for new Chimera dir structure. Makes single click on a DL link now automatically download thelink to the user's specified download folder (from the Internet pref pane in System Preferences) and invoke the appropriate helper app.
Attachment #96087 -
Attachment is obsolete: true
Assignee | ||
Comment 19•22 years ago
|
||
Setting milestone so it'll show up in the right place in my bug queries
Status: NEW → ASSIGNED
Target Milestone: --- → Chimera0.5
Comment 20•22 years ago
|
||
Most of the patch has been checked in, except for the CHBrowserService::Show part. I'm worried both about how the download dialog UI now matches up with the behaviour, and about the security implications of launching downloaded files without user intervention.
Assignee | ||
Comment 21•22 years ago
|
||
In our more security conscious world I wouldn't disagree that we could test the DL'd file to see if it's execuatble and not open it if that's the case. Since most Mac downloads aren't going to be executable files I don't think this will be a hinderance to Mac users.
Comment 22•22 years ago
|
||
are we still targetting this for 0.5?
Comment 23•22 years ago
|
||
*** Bug 167301 has been marked as a duplicate of this bug. ***
Assignee | ||
Updated•22 years ago
|
Target Milestone: Chimera0.5 → ---
Assignee | ||
Updated•22 years ago
|
Target Milestone: --- → Chimera0.7
Assignee | ||
Comment 24•22 years ago
|
||
*** Bug 163886 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 25•22 years ago
|
||
This is now fully landed but controlled by the pref implemented for bug #169044
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 26•22 years ago
|
||
Verified in the 2002-11-22-04 NB. Helper app automatically launchs when DL is finished.
Status: RESOLVED → VERIFIED
Comment 27•22 years ago
|
||
Only partially fixed for me in 2002112204. At http://homepage.mac.com/castiglione/ clicking on "Source Code: ServicesMenu.sit" downloads ServicesMenu.sit and launches Stuffit Expander; however, clicking on "Download FocusLayer v1.2" downloads FocusLayer.dmg but does not open it with Disk Copy or anything else.
Assignee | ||
Comment 28•22 years ago
|
||
That could actually be considered a security 'feature' as automatically mounting a disk image could result in an application being run from the image without the user's awareness. Not that we're doing this on purpose so I do need to find out what's happening in uriloader to cause it.
Comment 29•22 years ago
|
||
This doesn't work for me at all with 2002112204. Files get downloaded, but no post-processing occurs. I added the browser.download.autoDispatch line to my user.js file.
You need to log in
before you can comment on or make changes to this bug.
Description
•