Closed Bug 1510481 Opened 3 years ago Closed 3 years ago
Fix handling of messages sent to NSAutorelease
Pools after diverging from the recording
Bug 1508693 modified the handling for how we deal with autorelease pools being created and accessed after diverging from the recording, in order to distinguish these from other kinds of NS objects that we might need to send [alloc] and [init] messages to. This handling is broken, however, as it does not work right in cases where the pool was allocated before diverging from the recording, and then accessed afterwards: we will still allocate the pool in the middleman but won't be able to process messages sent to it, leading to repaint failures. The attached patch changes this so that we now perform middleman calls for the messages related to autorelease pools, but the handling of these messages is tweaked so that the pools are not actually allocated in the middleman (which causes all sorts of problems).
Attachment #9028121 - Flags: review?(lsmyth)
Attachment #9028121 - Flags: review?(lsmyth) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e17e9b14a434 Fix handling of messages sent to NSAutoreleasePools after diverging from the recording, r=lsmyth.
You need to log in before you can comment on or make changes to this bug.