Closed Bug 1510481 Opened 9 months ago Closed 9 months ago

Fix handling of messages sent to NSAutoreleasePools after diverging from the recording

Categories

(Core :: Web Replay, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: bhackett, Assigned: bhackett)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Bug 1508693 modified the handling for how we deal with autorelease pools being created and accessed after diverging from the recording, in order to distinguish these from other kinds of NS objects that we might need to send [alloc] and [init] messages to.  This handling is broken, however, as it does not work right in cases where the pool was allocated before diverging from the recording, and then accessed afterwards: we will still allocate the pool in the middleman but won't be able to process messages sent to it, leading to repaint failures.

The attached patch changes this so that we now perform middleman calls for the messages related to autorelease pools, but the handling of these messages is tweaked so that the pools are not actually allocated in the middleman (which causes all sorts of problems).
Attachment #9028121 - Flags: review?(lsmyth)
Attachment #9028121 - Flags: review?(lsmyth) → review+
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e17e9b14a434
Fix handling of messages sent to NSAutoreleasePools after diverging from the recording, r=lsmyth.
https://hg.mozilla.org/mozilla-central/rev/e17e9b14a434
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.