1510486 - will-change for individual transform properties should set WillChangeBits::TRANSFORM

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, enhancement, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

Otherwise our optimization in ActiveLayerTracker doesn't work fine for the properties, I believe.

We should add the properties here 
https://hg.mozilla.org/mozilla-central/file/204cda758118/servo/components/style/values/specified/box.rs#l491

Or we should introduce a new flag for the will change transform bit.

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 1510486 - Set WillChangeBits::TRANSFORM for individual transform.

We always check StyleWillChangeBits_TRANSFORM bit together with a
transform-like property set, so using WillChangeBits::TRANSFORM bit to
represent all transform-like properties is ok.

However, it seems the new test case works well even if we don't have this
patch. I still add it for individual transform properties to make sure
the test coverage is enough anyway.

Comment 2

[Boris Chiou [:boris]]

Attachment: Bug 1510486 - Add reftests for creating stacking-context and fixpos containing block on individual transforms.

To make sure the test coverage is enough for individual transforms.

Comment 3

[Boris Chiou [:boris]]

Got test_will_change.html failed on mac. I'm looking at it on mac now.

Comment 4

[Boris Chiou [:boris]]

(In reply to Boris Chiou [:boris] from comment #3)

Got test_will_change.html failed on mac. I'm looking at it on mac now.

My bad. I should set pref in chrome.ini because we use translate in the style sheet, too.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/83d5c6144840
Set WillChangeBits::TRANSFORM for individual transform. r=hiro
https://hg.mozilla.org/integration/autoland/rev/40de8675c53c
Add reftests for creating stacking-context and fixpos containing block on individual transforms. r=hiro

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/83d5c6144840
https://hg.mozilla.org/mozilla-central/rev/40de8675c53c

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

WPT import in https://github.com/web-platform-tests/wpt/pull/19451.