Closed Bug 1510486 Opened Last year Closed 4 months ago

will-change for individual transform properties should set WillChangeBits::TRANSFORM

Categories

(Core :: CSS Transitions and Animations, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla71
Tracking Status
firefox65 --- wontfix
firefox71 --- fixed

People

(Reporter: hiro, Assigned: boris)

References

Details

Attachments

(2 files)

Otherwise our optimization in ActiveLayerTracker doesn't work fine for the properties, I believe.

We should add the properties here 
https://hg.mozilla.org/mozilla-central/file/204cda758118/servo/components/style/values/specified/box.rs#l491

Or we should introduce a new flag for the will change transform bit.
Blocks: individual-transform
No longer blocks: 1207734
Blocks: 1424900
No longer blocks: individual-transform
Assignee: nobody → boris.chiou
See Also: → 1572797
See Also: 1572797

We always check StyleWillChangeBits_TRANSFORM bit together with a
transform-like property set, so using WillChangeBits::TRANSFORM bit to
represent all transform-like properties is ok.

However, it seems the new test case works well even if we don't have this
patch. I still add it for individual transform properties to make sure
the test coverage is enough anyway.

To make sure the test coverage is enough for individual transforms.

Got test_will_change.html failed on mac. I'm looking at it on mac now.

(In reply to Boris Chiou [:boris] from comment #3)

Got test_will_change.html failed on mac. I'm looking at it on mac now.

My bad. I should set pref in chrome.ini because we use translate in the style sheet, too.

Pushed by bchiou@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/83d5c6144840
Set WillChangeBits::TRANSFORM for individual transform. r=hiro
https://hg.mozilla.org/integration/autoland/rev/40de8675c53c
Add reftests for creating stacking-context and fixpos containing block on individual transforms. r=hiro
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla71
You need to log in before you can comment on or make changes to this bug.