Closed
Bug 1510511
Opened 6 years ago
Closed 6 years ago
Show console separator after the paused message
Categories
(Core Graveyard :: Web Replay, defect)
Core Graveyard
Web Replay
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1511043
People
(Reporter: bhackett1024, Assigned: bhackett1024)
References
Details
Attachments
(3 files)
851 bytes,
patch
|
Details | Diff | Splinter Review | |
168.28 KB,
image/png
|
Details | |
173.35 KB,
image/png
|
Details |
Currently the separator in the console appears before the paused message in the console, instead of after that message where it should be. I thought this was because the styling for this separator is in .message.paused::before, but changing this to .message.paused::after doesn't change anything. The attached patch changes the separator to be drawn by setting a style for the message's border-bottom. This isn't perfect but it is simple; I'm no CSS wizard so let me know if there is a better way to handle this.
Attachment #9028156 -
Flags: review?(jlaster)
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Comment 3•6 years ago
|
||
Thanks. I wasn't sure which was right. I'm happy to tweak this tomorrow. Here are some quick thoughts. - we should show the separation on top of you're payed before the first message. - we should use ::before so we don't affect layout and push things down - we should use a CSS color variable and have some opacity.
Comment 4•6 years ago
|
||
This will be fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=1511043
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
Updated•5 years ago
|
Attachment #9028156 -
Flags: review?(jlaster)
Updated•4 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•