Closed Bug 1510513 Opened 1 year ago Closed 1 year ago

Retain the formatting of MOZ_DEFINE_ENUM_* macros

Categories

(Firefox Build System :: Lint and Formatting, defect)

defect
Not set

Tracking

(firefox-esr60 fixed, firefox65 fixed)

RESOLVED FIXED
mozilla65
Tracking Status
firefox-esr60 --- fixed
firefox65 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

These macros tend to be handled quite poorly since the clang-format
tokenizer cannot figure out how to handle them.
Blocks: clang-format
These macros tend to be handled quite poorly since the clang-format
tokenizer cannot figure out how to handle them.
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/628d20bae43f
Retain the formatting of MOZ_DEFINE_ENUM_* macros r=sylvestre
https://hg.mozilla.org/mozilla-central/rev/628d20bae43f
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Attached patch ESR patchSplinter Review
[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.

User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This is a comment only change.

String or UUID changes made by this patch: None
Attachment #9031018 - Flags: approval-mozilla-esr60?
Comment on attachment 9031018 [details] [diff] [review]
ESR patch

OK for uplift to ESR60 as part of the clang-format project.
Attachment #9031018 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Target Milestone: Firefox 65 → mozilla65
You need to log in before you can comment on or make changes to this bug.