Closed
Bug 1510535
Opened 6 years ago
Closed 6 years ago
Restore comment in .clang-format-ignore
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla65
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
lizzard
:
approval-mozilla-esr60+
|
Details | Review |
Bug 1510128 removed a comment that was pretty helpful IMO.
Assignee | ||
Comment 1•6 years ago
|
||
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2449004c31ff Restore a few lines in .clang-format-ignore. r=tcampbell,sylvestre
Comment 3•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2449004c31ff
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Comment 4•5 years ago
|
||
Comment on attachment 9028208 [details] Bug 1510535 - Restore a few lines in .clang-format-ignore. r?tcampbell!,sylvestre! [ESR Uplift Approval Request] If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format. User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future. Fix Landed on Version: 65 Risk to taking this patch: Low Why is the change risky/not risky? (and alternatives if risky): This is NPOTB String or UUID changes made by this patch: None
Attachment #9028208 -
Flags: approval-mozilla-esr60?
Updated•5 years ago
|
status-firefox-esr60:
--- → affected
Comment 5•5 years ago
|
||
Comment on attachment 9028208 [details] Bug 1510535 - Restore a few lines in .clang-format-ignore. r?tcampbell!,sylvestre! OK for uplift to ESR60 as part of the clang-format project.
Attachment #9028208 -
Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
Comment 6•5 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-esr60/rev/2d177480ed27
You need to log in
before you can comment on or make changes to this bug.
Description
•