Closed Bug 1510535 Opened Last year Closed Last year

Restore comment in .clang-format-ignore

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox-esr60 --- fixed
firefox65 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

Bug 1510128 removed a comment that was pretty helpful IMO.
Pushed by jdemooij@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2449004c31ff
Restore a few lines in .clang-format-ignore. r=tcampbell,sylvestre
https://hg.mozilla.org/mozilla-central/rev/2449004c31ff
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Comment on attachment 9028208 [details]
Bug 1510535 - Restore a few lines in .clang-format-ignore. r?tcampbell!,sylvestre!

[ESR Uplift Approval Request]

If this is not a sec:{high,crit} bug, please state case for ESR consideration: This is required for easier backporting of patches after the reformatting of ESR using clang-format.

User impact if declined: Declining this will negatively impact our developers' ability to easily backport their patches to ESR in the future.

Fix Landed on Version: 65

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): This is NPOTB

String or UUID changes made by this patch: None
Attachment #9028208 - Flags: approval-mozilla-esr60?
Comment on attachment 9028208 [details]
Bug 1510535 - Restore a few lines in .clang-format-ignore. r?tcampbell!,sylvestre!

OK for uplift to ESR60 as part of the clang-format project.
Attachment #9028208 - Flags: approval-mozilla-esr60? → approval-mozilla-esr60+
You need to log in before you can comment on or make changes to this bug.