1510571 - remove some unneeded includes in mailnews/

Status: RESOLVED FIXED

(MailNews Core :: Backend, task, P5)

Description

[:aceman]

+++ This bug was initially created as a clone of Bug #1460049 +++

There are some includes in the /mailnews c++ files (.h, .cpp, .mm, .idl) that seem unneeded, the code does not use any identifier from the included file.
I've made a quick script to identify where nsI* objects aren't used in the file, but nsI*.h file is included. Many of them are unneeded.
Cleaning up the needless includes may speed up compiling by a tiny bit ;)

I will attach several patches into this bug that cover the individual code directories under /mailnews.
There is no priority to check them in after review.
Jorg, you can use the patches for check-ins when needed, similar to bug 1399756.

Comment 1

[:aceman]

Attachment: 1510571.patch nsMsgMessageFlags

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&selectedJob=215486305&revision=b61abd43b2977e4c1238ba66e6e46253582b19cd

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 9029706 [details] [diff] [review]
1510571.patch nsMsgMessageFlags

Looks OK. I don't quite understand the magic that removes some includes and adds others (in fact more than were removed), but I assume you've automated this.

Comment 3

[:aceman]

It's that the includes are added to files that actually use the symbols, and removed from files that don't.
Yes, in this case it is missing in more files. It would probably work without adding them, because it would still be included via some other header, but I don't want to rely on that.

If you do something like
https://searchfox.org/comm-central/search?q=nsMsgMessageFlags&case=false&regexp=false&path=.cpp
it can be nicely seen which files use nsMsgMessageFlags but do not include the header.

Comment 4

[:aceman]

Attachment: 1510571.patch v1.1

Refreshed the patch.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/38fad21bebd4
clean up some includes of nsMsgMessageFlags.h and use of Ci.nsMsgMessageFlags. r=jorgk