Use nsIURIFixup.createExposableURI more often

RESOLVED FIXED in Firefox 65

Status

()

enhancement
RESOLVED FIXED
6 months ago
2 months ago

People

(Reporter: baku, Assigned: baku)

Tracking

Trunk
mozilla65
Points:
---

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

6 months ago
There are a couple of places where use NS_MutateURI().SetUserPass() instead of nsIURIFixup::createExposableURI.

We should also remove the browser.fixup.hide_user_pass pref: it's not used in m-c and in c-c.
Assignee

Comment 1

6 months ago
Attachment #9028274 - Flags: review?(valentin.gosu)
Assignee

Comment 2

6 months ago
Attachment #9028275 - Flags: review?(valentin.gosu)
Comment on attachment 9028275 [details] [diff] [review]
part 2 - browser.fixup.hide_user_pass pref

Review of attachment 9028275 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent!
Attachment #9028275 - Flags: review?(valentin.gosu) → review+
Comment on attachment 9028274 [details] [diff] [review]
part 1 - netwerk

Review of attachment 9028274 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #9028274 - Flags: review?(valentin.gosu) → review+

Comment 5

6 months ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3241939e39a9
Use nsIURIFixup in netwerk/protocol/http, r=valentin
https://hg.mozilla.org/integration/mozilla-inbound/rev/d43ea215ccee
Remove browser.fixup.hide_user_pass pref, r=valentin

Comment 6

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3241939e39a9
https://hg.mozilla.org/mozilla-central/rev/d43ea215ccee
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.