Closed Bug 1510580 Opened 2 years ago Closed 2 years ago

Use nsIURIFixup.createExposableURI more often

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(2 files)

There are a couple of places where use NS_MutateURI().SetUserPass() instead of nsIURIFixup::createExposableURI.

We should also remove the browser.fixup.hide_user_pass pref: it's not used in m-c and in c-c.
Attached patch part 1 - netwerkSplinter Review
Attachment #9028274 - Flags: review?(valentin.gosu)
Attachment #9028275 - Flags: review?(valentin.gosu)
Comment on attachment 9028275 [details] [diff] [review]
part 2 - browser.fixup.hide_user_pass pref

Review of attachment 9028275 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent!
Attachment #9028275 - Flags: review?(valentin.gosu) → review+
Comment on attachment 9028274 [details] [diff] [review]
part 1 - netwerk

Review of attachment 9028274 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.
Attachment #9028274 - Flags: review?(valentin.gosu) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3241939e39a9
Use nsIURIFixup in netwerk/protocol/http, r=valentin
https://hg.mozilla.org/integration/mozilla-inbound/rev/d43ea215ccee
Remove browser.fixup.hide_user_pass pref, r=valentin
https://hg.mozilla.org/mozilla-central/rev/3241939e39a9
https://hg.mozilla.org/mozilla-central/rev/d43ea215ccee
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.