Closed Bug 1510591 Opened Last year Closed Last year
Try: Decision task breaks when push contains a changeset with an empty commit message
47 bytes, text/x-phabricator-request
|Details | Review|
Today, :padenot hit because of this push. This was caused by . I don't have the full context around these changes. Tom, would you mind taking a look at it?  https://taskcluster-artifacts.net/Gp41N1ujQIaQEh7exSXJBQ/0/public/logs/live_backing.log  https://treeherder.mozilla.org/#/jobs?repo=try&revision=36a75cd5ffd12a6710ab2115b73c3e53277a5123  https://searchfox.org/mozilla-central/diff/dc0ad39bd48520ada43fcfd7d88adf7fec94dc78/taskcluster/taskgraph/files_changed.py#40 (no bug on file)
Summary: TryL Decision task breaks when push contains a changeset with an empty commit message → Try: Decision task breaks when push contains a changeset with an empty commit message
[task 2018-11-28T13:30:11.261Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/files_changed.py", line 42, in get_changed_files [task 2018-11-28T13:30:11.261Z] desc=c['desc'].splitlines().encode('ascii', 'ignore')))
c['desc'].splitlines() raises an error because .splitlines() returns an empty list, rather than a one element list with an empty string when c['desc'] is ''. So test for c['desc'] first and then set it.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/4e1a901cc0a5 Fix 'get_changed_files' to cope with empty commit messages. r=dustin
Assignee: nobody → bugspam.Callek
Target Milestone: Firefox 65 → mozilla65
You need to log in before you can comment on or make changes to this bug.