1510616 - TEST-UNEXPECTED-FAIL | [snip]mozmill/folder-display/test-columns.js and folder-display/test-right-click-middle-click-messages.js

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Jorg K (CEST = GMT+2)]

TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1543408195/build/tests/mozmill/folder-display/test-columns.js | test-columns.js::test_reset_to_inbox
TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1543408195/build/tests/mozmill/folder-display/test-columns.js | test-columns.js::test_apply_to_folder_no_children
TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1543408195/build/tests/mozmill/folder-display/test-columns.js | test-columns.js::test_apply_to_folder_and_children
TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1543408195/build/tests/mozmill/folder-display/test-columns.js | test-columns.js::test_apply_to_folder_no_children_swapped
TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1543408195/build/tests/mozmill/folder-display/test-columns.js | test-columns.js::test_apply_to_folder_and_children_swapped
TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1543408195/build/tests/mozmill/folder-display/test-columns.js | test-columns.js::test_reset_columns_gloda_collection
TEST-UNEXPECTED-FAIL | /Users/cltbld/tasks/task_1543408195/build/tests/mozmill/folder-display/test-right-click-middle-click-messages.js | test-right-click-middle-click-messages.js::test_right_click_column_header_shows_col_picker

M-C last good: a12d80e08655c13245add6f6dacc91f8a6
M-C first bad: 5c66354bff282452a6f1a3c911fa8756b6
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a12d80e08655c13245add6f6dacc91f8a6&tochange=5c66354bff282452a6f1a3c911fa8756b6

Must be
4b9f8acdf5f7 Victor Porof - Bug 1503824 - Migrate the treecols binding into a custom element. r=bgrins

Someone of the de-XBL team care to take a look.

https://taskcluster-artifacts.net/L_m-yiCcRXm6Z_4yUK-a7g/0/public/logs/live_backing.log
Search for
EXCEPTION: mc.window.document.getAnonymousNodes(...) is null; can't access its "item" property

Plenty there :-(

Comment 1

[Magnus Melin [:mkmelin]]

05:01:44     INFO -  SUMMARY-UNEXPECTED-FAIL | test-right-click-middle-click-messages.js | test-right-click-middle-click-messages.js::test_right_click_column_header_shows_col_picker
05:01:44     INFO -    EXCEPTION: mc.window.document.getAnonymousNodes(...) is null; can't access its "item" property
05:01:44     INFO -      at: test-right-click-middle-click-messages.js line 80
05:01:44     INFO -         test_right_click_column_header_shows_col_picker test-right-click-middle-click-messages.js:80 23
05:01:44     INFO -         Runner.prototype.wrapper frame.js:584 9
05:01:44     INFO -         Runner.prototype._runTestModule frame.js:654 9
05:01:44     INFO -         Runner.prototype.runTestModule frame.js:700 3
05:01:44     INFO -         Runner.prototype.runTestDirectory frame.js:524 7
05:01:44     INFO -         runTestDirectory frame.js:706 3
05:01:44     INFO -         Bridge.prototype._execFunction server.js:177 10
05:01:44     INFO -         Bridge.prototype.execFunction server.js:181 16
05:01:44     INFO -         Session.prototype.receive server.js:282 3
05:01:44     INFO -         AsyncRead.prototype.onDataAvailable server.js:88 3

https://searchfox.org/comm-central/source/mail/test/mozmill/folder-display/test-right-click-middle-click-messages.js#80

Comment 2

[Tim Nguyen :ntim]

let treeColPicker = mc.window.document.getAnonymousNodes(threadCols).item(1);

can be replaced with:

let treeColPicker = threadCols.querySelector("treecolpicker");

Comment 3

[Jorg K (CEST = GMT+2)]

Thanks Tim, but no luck with that suggestion. In fact, it makes a bunch of other subtests fail as well.

Comment 4

[Jorg K (CEST = GMT+2)]

Attachment: 1510616-disable-tests.patch

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/42d96198196c
disable some failing MozMill subtests in folder-display. rs=bustage-fix

Comment 6

[Jorg K (CEST = GMT+2)]

Magnus, you're going to take this bug? I'm not sure what comment #1 was going to tell us.

Comment 7

[Magnus Melin [:mkmelin]]

The comment was just to make it easier to find the exact rows to start looking. I guess I can take this on.

Comment 8

[:aceman]

Attachment: 1510616.patch

Actually ntim's suggestion was fine, thanks.

This fixes the tests and also rightlicking the column headers to get the column picker (in the folder pane and thread pane).

Try run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=9eb7b9fcb84a6893097f7565d18981a3e4dc7f96

Comment 9

[Magnus Melin [:mkmelin]]

Comment on attachment 9029109 [details] [diff] [review]
1510616.patch

Review of attachment 9029109 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thx! r=mkmelin

Comment 10

[:aceman]

Thanks.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f93942f170c4
fix getting treecolpicker element on folder tree after bug 1503824. r=mkmelin