1510631 - toolbuttons placed next to menubar unexpectedly move to the right most end

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Alice0775 White]

This bug may confuse existing users at the future 65 release(or beta).
No reason to change toolbutton position.


Reproducible: always

Steps To Reproduce:
1. Start Firefox64beta with new profile
2. Enable Menubar and place toolbutton next to menubar
3. Quit Firefox64

4. Start Nightly65 with the same profile

Actual Results: 
Toolbuttons placed next to menubar unexpectedly move to the right most end.
See screenshot: https://www.youtube.com/watch?v=JReQzVZqDNk

Expected Results:
Toolbuttons should be placed same position.



Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5e887c4ebd791fc491977bdc0ee8fc787f46b33a&tochange=d476f054342f039445afddff474f4c8b4d9edea2

Regressed by: d476f054342f	Mike Conley — Bug 1507536 - Set skipintoolbarset="true" on some titlebar items to avoid redundant context menu items. r=dao

Comment 1

[:Gijs (he/him)]

Mike, is this by design? It doesn't seem to have been considered explicitly in bug 1507536...

Comment 3

[:Gijs (he/him)]

Per attachment 9027229 [details] (from the dupe) this really doesn't work well for the bookmarks toolbar items. It's possible other items also look particuarly odd with this setup.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

*sigh*

Thanks for filing, folks. Sorry for the breakage.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1510631 - Allow items to be placed on the left of the toolbar menubar spacer. r?Gijs

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/87ba3805b069
Allow items to be placed on the left of the toolbar menubar spacer. r=Gijs

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/87ba3805b069

Comment 8

[Peter L Jones]

Attachment: vertical_align_good.png

Comment 9

[Peter L Jones]

Attachment: vertical_align_bad.png

Comment 10

[Peter L Jones]

Comment on attachment 9028709 [details]
vertical_align_good.png

From firefox-63.0.3 on Ubuntu

Comment 11

[Peter L Jones]

Comment on attachment 9028710 [details]
vertical_align_bad.png

From 65.0a1 (2018-11-29) on Windows 10

Comment 12

[Peter L Jones]

Still not perfect.  vertical_align_good.png and vertical_align_bad.png show how the vertical alignment has been broken.

Comment 13

[Dão Gottwald [:dao]]

(In reply to Peter L Jones from comment #12)
> Still not perfect.  vertical_align_good.png and vertical_align_bad.png show
> how the vertical alignment has been broken.

Please file a new bug.

Comment 14

[Peter L Jones]

(In reply to Dão Gottwald [::dao] from comment #13)
Filed as https://bugzilla.mozilla.org/show_bug.cgi?id=1511106

Comment 15

[Anca Soncutean, Desktop QA]

I’ve reproduced this issue by using the steps from bug’s description, with Beta 64.0b12 and Nightly 65.0a1(2018-11-23) on Windows 10 x64. 

The issue is fixed by following the same scenario with Beta 65.0b8 and Nightly 66.0a1 (2019-01-04) on Windows 10 x64 and Ubuntu 18 x64.