1510654 - [remote-dbg-next] Remove usage of client.request() for service workers

Status: RESOLVED FIXED

(DevTools :: about:debugging, enhancement, P1)

Description

[Julian Descottes [:jdescottes]]

We should cleanup all the call sites in about:debugging that still rely on client.request: 

https://searchfox.org/mozilla-central/search?q=clientWrapper.request&case=false&regexp=false&path=

Instead to be consistent, we should get a front for the service worker and call methods on it.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1510654 - Extract ServiceWorkerRegistrationList from worker-list.js;r=ochameau,ladybenko

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1510654 - Move worker/worker-list.js to targets/worker-list;r=ochameau,ladybenko

Depends on D15374

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1510654 - Create fronts for ServiceWorkerRegistration, PushSubscription and ServiceWorker;r=ochameau,ladybenko

Depends on D15375

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1510654 - Return ServiceWorker fronts for installing, active and waiting workers;r=ochameau,ladybenko

Depends on D15376

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1510654 - Extract service worker actors to dedicated files;r=ochameau,ladybenko

Depends on D15377

Comment 6

[Julian Descottes [:jdescottes]]

Green try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a8dd2c3042d93a76fd10e928b77ea1e3d124979

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1510654 - Remove request API from client wrapper;r=ladybenko

Depends on D15378. This is an additional cleanup I forgot to include in the earlier patches.
We no longer use the request API in about:debugging so we can remove it from our wrapper.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ca78d645eed
Extract ServiceWorkerRegistrationList from worker-list.js;r=ochameau,ladybenko
https://hg.mozilla.org/integration/autoland/rev/2ecae1ee43a0
Move worker/worker-list.js to targets/worker-list;r=ochameau,ladybenko
https://hg.mozilla.org/integration/autoland/rev/a2289d2698b7
Create fronts for ServiceWorkerRegistration, PushSubscription and ServiceWorker;r=ochameau,ladybenko
https://hg.mozilla.org/integration/autoland/rev/247e6818b262
Return ServiceWorker fronts for installing, active and waiting workers;r=ochameau,ladybenko
https://hg.mozilla.org/integration/autoland/rev/08b043c4ef1b
Extract service worker actors to dedicated files;r=ochameau,ladybenko
https://hg.mozilla.org/integration/autoland/rev/ab1bfb032425
Remove request API from client wrapper;r=ladybenko

Comment 9

[Julian Descottes [:jdescottes]]

Attachment: Bug 1510654 - Reorder specs to be alphabetically sorted;r=fix

Depends on D16022 . Minor fix, just reordering a spec definition.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/639924062722
Reorder specs to be alphabetically sorted;

Comment 11

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/8ca78d645eed
https://hg.mozilla.org/mozilla-central/rev/2ecae1ee43a0
https://hg.mozilla.org/mozilla-central/rev/a2289d2698b7
https://hg.mozilla.org/mozilla-central/rev/247e6818b262
https://hg.mozilla.org/mozilla-central/rev/08b043c4ef1b
https://hg.mozilla.org/mozilla-central/rev/ab1bfb032425
https://hg.mozilla.org/mozilla-central/rev/639924062722