Closed
Bug 1510689
Opened 6 years ago
Closed 6 years ago
Build bustages on nsGlobalWindowOuter.cpp when Gecko 65 merges to Beta on 2018-12-03
Categories
(Core :: DOM: Core & HTML, defect, P2)
Core
DOM: Core & HTML
Tracking
()
VERIFIED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox63 | --- | unaffected |
| firefox64 | --- | unaffected |
| firefox65 | --- | verified |
People
(Reporter: NarcisB, Assigned: bzbarsky)
References
Details
Attachments
(1 file)
|
1.06 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
Central as beta simulation: https://treeherder.mozilla.org/#/jobs?repo=try&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&selectedJob=214383386&revision=52f6b1db5a462d0a4981ffda38bb9df9cb56f567 Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=214383386&repo=try&lineNumber=19910 Boris, this is caused by https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&revision=95651672782a47a2031a4ea492f85053c98d5769 Coul you please take a look?
Flags: needinfo?(bzbarsky)
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #9028360 -
Flags: review?(peterv)
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•6 years ago
|
||
This will fix the build issue. There will be test failures, however. I can try to rewrite the tests to expect different behavior on nightly and beta, or we could just apply a patch to the tests after the merge...
Flags: needinfo?(bzbarsky)
|
||
Updated•6 years ago
|
Priority: -- → P2
|
||
Updated•6 years ago
|
Attachment #9028360 -
Flags: review?(peterv) → review+
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/mozilla-central/rev/9ad82455dcee Only define IsNonConfigurableReadonlyPrimitiveGlobalProp if we plan to use it. r=peterv a=Aryx,beta-fix
|
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9ad82455dcee
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
|
|
||
Updated•6 years ago
|
Status: RESOLVED → VERIFIED
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•