Closed Bug 1510708 Opened 9 months ago Closed 9 months ago

Don't update UI on intermediate points reached while warping

Categories

(Core :: Web Replay, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: bhackett, Assigned: bhackett)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
When doing a warp (aka seek, need to rename things in the code soon...) to a point in the past, the debugger gets an _onPause notification after the child rewinds to the last saved checkpoint before the target of the warp.  This triggers a call to the position change handler and the UI updates, reflecting a different paused location from the target of the warp.  This is distracting, and the UI shouldn't update until the warp finishes.  Calling _onPause here is problematic for another reason: the child will be immediately resumed internally and the debugger's _paused flag will be set incorrectly for a little while.

The attached patch fixes these problems by not sending an _onPause notification to the debugger for this intermediate pause.
Attachment #9028387 - Flags: review?(continuation)
Attachment #9028387 - Flags: review?(continuation) → review+
Pushed by bhackett@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d44f09e1a87b
Don't send OnPaused notification to debugger for intermediate checkpoint when warping, r=mccr8.
https://hg.mozilla.org/mozilla-central/rev/d44f09e1a87b
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.