1510708 - Don't update UI on intermediate points reached while warping

Status: RESOLVED FIXED

(Core Graveyard :: Web Replay, defect)

Description

[Brian Hackett [Laid off!]]

Attachment: patch

When doing a warp (aka seek, need to rename things in the code soon...) to a point in the past, the debugger gets an _onPause notification after the child rewinds to the last saved checkpoint before the target of the warp.  This triggers a call to the position change handler and the UI updates, reflecting a different paused location from the target of the warp.  This is distracting, and the UI shouldn't update until the warp finishes.  Calling _onPause here is problematic for another reason: the child will be immediately resumed internally and the debugger's _paused flag will be set incorrectly for a little while.

The attached patch fixes these problems by not sending an _onPause notification to the debugger for this intermediate pause.

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d44f09e1a87b
Don't send OnPaused notification to debugger for intermediate checkpoint when warping, r=mccr8.

Comment 2

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/d44f09e1a87b